Skip to content

Add dungeoneering shop and completion interfaces - #1145

Merged
GregHib merged 9 commits into
mainfrom
dungeoneering-ifaces
Aug 7, 2026
Merged

Add dungeoneering shop and completion interfaces#1145
GregHib merged 9 commits into
mainfrom
dungeoneering-ifaces

Conversation

@GregHib

@GregHib GregHib commented Aug 7, 2026

Copy link
Copy Markdown
Owner

No description provided.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Qodana for JVM

3 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 2
Constant conditions 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.99631% with 187 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.01%. Comparing base (8422285) to head (48db197).

Files with missing lines Patch % Lines
.../kotlin/content/skill/dungeoneering/DungeonShop.kt 12.19% 72 Missing ⚠️
...lin/content/skill/dungeoneering/DungeonComplete.kt 7.69% 36 Missing ⚠️
...main/kotlin/content/entity/npc/shop/buy/ShopBuy.kt 41.02% 13 Missing and 10 partials ⚠️
...main/kotlin/content/skill/dungeoneering/Toolkit.kt 16.66% 15 Missing ⚠️
...in/kotlin/content/entity/npc/shop/sell/ShopSell.kt 60.00% 5 Missing and 7 partials ⚠️
...t/area/wilderness/daemonheim/DungeoneeringParty.kt 42.85% 5 Missing and 3 partials ⚠️
...n/content/entity/npc/shop/stock/ItemInformation.kt 0.00% 4 Missing ⚠️
...ontent/entity/player/inv/item/drop/ItemDropping.kt 73.33% 2 Missing and 2 partials ⚠️
...lin/content/area/wilderness/daemonheim/Smuggler.kt 0.00% 3 Missing ⚠️
...n/kotlin/content/entity/npc/shop/stock/ItemInfo.kt 82.35% 1 Missing and 2 partials ⚠️
... and 3 more
Additional details and impacted files
Files with missing lines Coverage Δ
...me/src/main/kotlin/content/entity/npc/shop/Shop.kt 38.88% <100.00%> (ø)
...t/area/wilderness/daemonheim/DungeonPartyInvite.kt 36.97% <50.00%> (ø)
...kotlin/content/skill/dungeoneering/DungeonDoors.kt 18.33% <0.00%> (-0.16%) ⬇️
...lin/content/area/wilderness/daemonheim/Smuggler.kt 5.55% <0.00%> (-0.13%) ⬇️
...n/kotlin/content/entity/npc/shop/stock/ItemInfo.kt 75.00% <82.35%> (-1.20%) ⬇️
...otlin/content/skill/dungeoneering/Dungeoneering.kt 3.65% <0.00%> (-0.05%) ⬇️
...n/content/entity/npc/shop/stock/ItemInformation.kt 25.00% <0.00%> (-2.59%) ⬇️
...ontent/entity/player/inv/item/drop/ItemDropping.kt 77.77% <73.33%> (-8.89%) ⬇️
...t/area/wilderness/daemonheim/DungeoneeringParty.kt 60.26% <42.85%> (-1.56%) ⬇️
...in/kotlin/content/entity/npc/shop/sell/ShopSell.kt 50.00% <60.00%> (-5.56%) ⬇️
... and 4 more
@@             Coverage Diff              @@
##               main    #1145      +/-   ##
============================================
- Coverage     44.08%   44.01%   -0.07%     
+ Complexity     9817     9814       -3     
============================================
  Files          1962     1965       +3     
  Lines         84831    85005     +174     
  Branches      14028    14062      +34     
============================================
+ Hits          37400    37419      +19     
- Misses        42028    42175     +147     
- Partials       5403     5411       +8     
Components Coverage Δ
Content 44.44% <30.99%> (-0.10%) ⬇️
Engine 45.59% <ø> (ø)
Network 71.36% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib
GregHib merged commit 369110e into main Aug 7, 2026
5 checks passed
@GregHib
GregHib deleted the dungeoneering-ifaces branch August 7, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant