Implementation of Gregicality Multiblocks#369
Merged
Conversation
fix ABS (no textures tho)
…/GregTechCEu-1.19 into gregicality-multiblocks
fix molten fluid texture (it was easy)
screret pls help
fix the issue
…-modes # Conflicts: # common/src/main/java/com/gregtechceu/gtceu/api/machine/WorkableTieredMachine.java # common/src/main/java/com/gregtechceu/gtceu/api/machine/fancyconfigurator/MachineModeFancyConfigurator.java # common/src/main/java/com/gregtechceu/gtceu/api/machine/feature/IRecipeLogicMachine.java # common/src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/WorkableElectricMultiblockMachine.java # common/src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/WorkableMultiblockMachine.java # common/src/main/java/com/gregtechceu/gtceu/api/machine/steam/SimpleSteamMachine.java # common/src/main/java/com/gregtechceu/gtceu/api/machine/steam/SteamWorkableMachine.java # common/src/main/java/com/gregtechceu/gtceu/api/machine/trait/RecipeLogic.java # common/src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/primitive/PrimitiveWorkableMachine.java # common/src/main/java/com/gregtechceu/gtceu/common/machine/steam/SteamLiquidBoilerMachine.java # common/src/main/java/com/gregtechceu/gtceu/common/machine/steam/SteamSolidBoilerMachine.java # common/src/main/java/com/gregtechceu/gtceu/common/machine/trait/miner/MinerLogic.java
…Eu-1.19 into machine-modes
… sense, etc. run data.
add the parallel hatch, fix a lot of bugs, rename the casings to make sense
screret
suggested changes
Sep 15, 2023
| .rotationState(RotationState.ALL) | ||
| .abilities(PartAbility.PARALLEL_HATCH) | ||
| .workableTieredHullRenderer(GTCEu.id("block/machines/parallel_hatch_mk" + (tier - 4))) | ||
| .tooltips(Component.translatable("gtceu.parallelhatch_mk"+tier)) |
Contributor
There was a problem hiding this comment.
also for the lang key you could do "gtceu.tooltip.parallel_hatch_mk" + (tier - 4)
screret
suggested changes
Sep 15, 2023
| .langValue("Alloy Blast Smelter") | ||
| .tooltips(Component.translatable("gtceu.multiblock.parallelizable.tooltip")) | ||
| .tooltips(Component.translatable("gtceu.machine.available_recipe_map_1.tooltip", Component.translatable("gtceu.recipemap.blast_alloy"))) | ||
| .tooltips(Component.translatable("gtceu.machine.available_recipe_map_1.tooltip", Component.translatable("gtceu.blast_alloy"))) |
Contributor
There was a problem hiding this comment.
i think this lang key should be gtceu.alloy_blast_smelter?
screret
reviewed
Sep 15, 2023
screret
approved these changes
Sep 15, 2023
screret
previously approved these changes
Sep 15, 2023
This was
linked to
issues
Sep 15, 2023
whatthedrunk
approved these changes
Sep 15, 2023
screret
added a commit
that referenced
this pull request
Sep 15, 2023
* gcmb first additions * fix ABS (no textures tho) * slight refactor * blast alloy changes * fix molten fluid texture (it was easy) * more refactoring * first attempt at implementing machine modes screret pls help * fix the issue * next attempt for the configurator * latest commit * latest stuff * change activerecipetype to int * final touch + method rename * dev QoL stuffs * final commit * run data * js^3 support added * final touch * Update GTRecipeTypes.java * Update GTMachines.java * gcmb first additions * slight refactor * fix ABS (no textures tho) * blast alloy changes * fix molten fluid texture (it was easy) * more refactoring * first attempt at implementing machine modes screret pls help * fix the issue * next attempt for the configurator * latest stuff * change activerecipetype to int * final touch + method rename * js^3 support added * dev QoL stuffs * run data * gcmb first additions * slight refactor * fix ABS (no textures tho) * blast alloy changes * fix molten fluid texture (it was easy) * gcmb first additions * fix ABS (no textures tho) * blast alloy changes * fix molten fluid texture (it was easy) * fix some KJS builders having issues in array indexing, rebase to upstream * fix some KJS builders having issues in array indexing, rebase to upstream HOLY SHIT THIS WAS PAINFUL * add the parallel hatch, fix a lot of bugs, rename the casings to make sense, etc. run data. * parallel hatches + missing multis * finalized * requested fixes * datagen * more requested changes + datagen * Update common/src/main/java/com/gregtechceu/gtceu/common/data/GCyMMachines.java --------- Co-authored-by: screret <68943070+screret@users.noreply.github.com>
screret
added a commit
that referenced
this pull request
Sep 15, 2023
* add a KJS block type for renderer blocks. (#353) * add ability to create renderer blocks from KJS, make the simple machines' arrays match the tier indexes * do the same to KJS machine builders * Implementation of Machine Modes (#359) * first attempt at implementing machine modes screret pls help * fix the issue * next attempt for the configurator * latest commit * latest stuff * change activerecipetype to int * final touch + method rename * dev QoL stuffs * final commit * run data * js^3 support added --------- Co-authored-by: screret <joona.v.stenberg@gmail.com> * shit. these should stack. * Implementation of Gregicality Multiblocks (#369) * gcmb first additions * fix ABS (no textures tho) * slight refactor * blast alloy changes * fix molten fluid texture (it was easy) * more refactoring * first attempt at implementing machine modes screret pls help * fix the issue * next attempt for the configurator * latest commit * latest stuff * change activerecipetype to int * final touch + method rename * dev QoL stuffs * final commit * run data * js^3 support added * final touch * Update GTRecipeTypes.java * Update GTMachines.java * gcmb first additions * slight refactor * fix ABS (no textures tho) * blast alloy changes * fix molten fluid texture (it was easy) * more refactoring * first attempt at implementing machine modes screret pls help * fix the issue * next attempt for the configurator * latest stuff * change activerecipetype to int * final touch + method rename * js^3 support added * dev QoL stuffs * run data * gcmb first additions * slight refactor * fix ABS (no textures tho) * blast alloy changes * fix molten fluid texture (it was easy) * gcmb first additions * fix ABS (no textures tho) * blast alloy changes * fix molten fluid texture (it was easy) * fix some KJS builders having issues in array indexing, rebase to upstream * fix some KJS builders having issues in array indexing, rebase to upstream HOLY SHIT THIS WAS PAINFUL * add the parallel hatch, fix a lot of bugs, rename the casings to make sense, etc. run data. * parallel hatches + missing multis * finalized * requested fixes * datagen * more requested changes + datagen * Update common/src/main/java/com/gregtechceu/gtceu/common/data/GCyMMachines.java --------- Co-authored-by: screret <68943070+screret@users.noreply.github.com> * it didnt build lol --------- Co-authored-by: Rundas <38040866+Rundas01@users.noreply.github.com>
screret
added a commit
that referenced
this pull request
Nov 23, 2023
* add a KJS block type for renderer blocks. (#353) * add ability to create renderer blocks from KJS, make the simple machines' arrays match the tier indexes * do the same to KJS machine builders * Implementation of Machine Modes (#359) * first attempt at implementing machine modes screret pls help * fix the issue * next attempt for the configurator * latest commit * latest stuff * change activerecipetype to int * final touch + method rename * dev QoL stuffs * final commit * run data * js^3 support added --------- Co-authored-by: screret <joona.v.stenberg@gmail.com> * shit. these should stack. * Implementation of Gregicality Multiblocks (#369) * gcmb first additions * fix ABS (no textures tho) * slight refactor * blast alloy changes * fix molten fluid texture (it was easy) * more refactoring * first attempt at implementing machine modes screret pls help * fix the issue * next attempt for the configurator * latest commit * latest stuff * change activerecipetype to int * final touch + method rename * dev QoL stuffs * final commit * run data * js^3 support added * final touch * Update GTRecipeTypes.java * Update GTMachines.java * gcmb first additions * slight refactor * fix ABS (no textures tho) * blast alloy changes * fix molten fluid texture (it was easy) * more refactoring * first attempt at implementing machine modes screret pls help * fix the issue * next attempt for the configurator * latest stuff * change activerecipetype to int * final touch + method rename * js^3 support added * dev QoL stuffs * run data * gcmb first additions * slight refactor * fix ABS (no textures tho) * blast alloy changes * fix molten fluid texture (it was easy) * gcmb first additions * fix ABS (no textures tho) * blast alloy changes * fix molten fluid texture (it was easy) * fix some KJS builders having issues in array indexing, rebase to upstream * fix some KJS builders having issues in array indexing, rebase to upstream HOLY SHIT THIS WAS PAINFUL * add the parallel hatch, fix a lot of bugs, rename the casings to make sense, etc. run data. * parallel hatches + missing multis * finalized * requested fixes * datagen * more requested changes + datagen * Update common/src/main/java/com/gregtechceu/gtceu/common/data/GCyMMachines.java --------- Co-authored-by: screret <68943070+screret@users.noreply.github.com> * it didnt build lol --------- Co-authored-by: Rundas <38040866+Rundas01@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shoutouts to Screret for the Parallel Hatches