Skip to content

Fix misuse of IO.BOTH by using .storage when needed - #5151

Merged
jurrejelle merged 5 commits into
1.20.1from
reab/fix-io-madness
Jul 25, 2026
Merged

Fix misuse of IO.BOTH by using .storage when needed#5151
jurrejelle merged 5 commits into
1.20.1from
reab/fix-io-madness

Conversation

@Reabstraction

Copy link
Copy Markdown
Contributor

What

Fixes item stuffs pulling stuff out of input slots outside of the UI

Implementation Details

I replaced every usage of new ItemSlot/new ModularSlot to point at storage and set accessibility, then I set the slots to not be IO.BOTH but instead the proper IO.IN

AI Usage

Good old CTRL+F and manual edits did the trick here

  • No AI driven tools were used for this pull request.
  • Yes AI driven tools were used for this pull request.

Outcome

Item input buses now no longer pull from input slots :D

How Was This Tested

I went in game, grabbed a bunch of multi-blocks and single-blocks and it worked fine, third-party testing appreciated.

Potential Compatibility Issues

Potentially this will break some designs that rely upon input items being taken out, but that is something you should not be doing anyways

Potential Other Issues

I have not validated fluid slots yet

@Reabstraction
Reabstraction requested a review from a team as a code owner July 19, 2026 19:43
@github-actions github-actions Bot added 1.20.1 Tests: Passed Game Tests have passed on this PR labels Jul 19, 2026
Comment thread src/main/java/com/gregtechceu/gtceu/common/mui/GTMuiMachineUtil.java Outdated
@jurrejelle
jurrejelle merged commit d5a9d80 into 1.20.1 Jul 25, 2026
4 checks passed
@jurrejelle
jurrejelle deleted the reab/fix-io-madness branch July 25, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 Tests: Passed Game Tests have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants