Closed
Conversation
TechLord22
added
the
status: high priority
brachy84
suggested changes
Dec 8, 2021
| if (distributed <= 0) | ||
| return; | ||
|
|
||
| long amperageUsed = energyContainer.acceptEnergyFromNetwork(outFacing.getOpposite(), distributed / getOutputAmperage(), getOutputAmperage()); |
Contributor
There was a problem hiding this comment.
shouldn't this be distributed * getOutputAmperage()?
(described issue on discord)
| private final BitSet batterySlotsUsedThisTick = new BitSet(); | ||
| private final int tier; | ||
| private long amps = 0; | ||
| private long lastEnergyInputPerSec = 0; |
Contributor
There was a problem hiding this comment.
you need to update these 4 values for the digital cover
serenibyss
added
status: do not merge
Merged
Member
|
Superseded by #323 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes 9 Slot buffers to 8 slots. Evenly distributes energy over all batteries when draining and filling.