Merged
Conversation
brachy84
approved these changes
Dec 10, 2021
Contributor
Author
|
Changes not notified: I also cherry picked Tech's battery buffer change so this should be ready to merge, unless you have requests. |
Closed
… into battery_containers
… into battery_containers
TechLord22
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
This PR tackles on wonky behaviors on the current battery buffer. Sections of the code are largely reworked for the sake of better functionality for gameplay.
How solved:
Splits energy received and exported to and from all the batteries evenly.
Uses an internal buffer for excess energy that didn't fit into the batteries, and re-uses it whenever possible.
Longer explanation from reading the code, which may give you headaches. Blame dan for refusing gt5-style battery buffers!
Outcome:
All energy coming in and out of the battery buffer will be split evenly between the batteries.
Battery buffer now accepts 2A per battery as input.
Battery buffer is now able to always fully fill or fully empty batteries.
Closes #302 once I cherry-pick the 9 -> 8 slots batt buffer.
Additional info:
EnergyContainerBatteryBuffernow extendsEnergyContainerHandlerinstead of being its own thing, to make use of parent methods and variables.Will render #302 obsolete.
Possible compatibility issue:
None expected.