chore: rebase Greptime thin fork onto DataFusion 54.1 - #21
Open
discord9 wants to merge 12 commits into
Open
Conversation
Signed-off-by: discord9 <discord9@163.com> (cherry picked from commit 7303323)
Signed-off-by: discord9 <discord9@163.com> (cherry picked from commit 467e7ec)
Signed-off-by: discord9 <discord9@163.com> (cherry picked from commit c349e4b)
Signed-off-by: discord9 <discord9@163.com> (cherry picked from commit 9297b40)
Signed-off-by: discord9 <discord9@163.com> (cherry picked from commit 557ddad)
Signed-off-by: discord9 <discord9@163.com> (cherry picked from commit e2be639)
Signed-off-by: discord9 <discord9@163.com> (cherry picked from commit d385af8)
Signed-off-by: discord9 <discord9@163.com> (cherry picked from commit fb7b26d)
Signed-off-by: discord9 <discord9@163.com> (cherry picked from commit 0273585)
Signed-off-by: discord9 <discord9@163.com> (cherry picked from commit 0f6dcb1)
Signed-off-by: discord9 <discord9@163.com> (cherry picked from commit cee35d9)
Signed-off-by: discord9 <discord9@163.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A — issues are disabled on this maintenance fork. This replacement is tracked by GreptimeDB PR #8555 and supersedes GreptimeTeam/datafusion#20.
Rationale for this change
GreptimeDB is upgrading from its DataFusion 53.1 maintenance branch to DataFusion 54.1. The first thin-fork proposal (#20) was built on official 54.0.0. Since then, official 54.1.0 shipped 20 backports, including an adapted version of the volatile file-scan projection fix that #20 carried locally.
This replacement starts from the exact official
54.1.0commit0d1f2ebe2cc97c91b736bc0a160b5b73cf40437a, drops the now-upstream volatile projection patch, and carries only the 12 correctness fixes still required by GreptimeDB. It keeps the organization branch reviewable instead of making the official 54.1 update appear as part of a PR based ongreptimedb-54.0.0.What changes are included in this PR?
Base:
Retained fixes, replayed with provenance from the validated 54.0 stack:
7303323513a60023a3a467e7ec99fe5cfcc3a8c349e4b388062d818d9array_resizeby Arrow's maximum array size9297b40fd4e4231af92557ddad236a286efa5dSortPreservingMergeExece2be63976c4b31e11d0d385af852d33f4161e7TRY_CASTscalar/array overflow behavior nullablefb7b26d04c218a14c53027358559b887df12d5median(NULL)and fall back from grouped accumulation0f6dcb128d450ac6b5cee35d94c33e6bb173ORDER BYrequirements belowScalarSubqueryExecroots9eae6da6f43a6b5750Explicitly not replayed:
adfae3451— official 54.1 contains the adapted fix asc735a49a3.The resulting candidate head is
43a6b575099e9d6002636814a28654235cdf213a, exactly 12 commits above the official 54.1 base.Are these changes tested?
Each retained semantic change has focused regression coverage from the original test-first port. The 54.1 replacement additionally requires:
0d1f2ebe2;cargo clippy --all-targets --all-features -- -D warnings;Actual completed evidence before submission:
0d1f2ebe2and an exact 12-commit range.projection_pushdown.slt.cargo fmt --all -- --checkgit diff --checkdatafusion-functions(284),datafusion-functions-aggregate(127),datafusion-optimizer(698 unit + 28 integration),datafusion-physical-expr(1,548; 1 ignored),datafusion-physical-plan(1,441), anddatafusion-substrait(49 unit + 197 integration; 6 ignored).cargo clippy --all-targets --all-features -- -D warnings.datafusion-physical-optimizerClippy.Are there any user-facing changes?
There is no intentional public API change beyond the official DataFusion 54.1 baseline. The retained patches correct query results, optimizer rewrites, statistics, memory accounting, NULL aggregation, Substrait schema reconstruction, and overflow behavior consumed by GreptimeDB.