docs: update configuration reference with new options and formatting - #2636
Conversation
Deploying greptime-docs with
|
| Latest commit: |
434e5ef
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://335165b5.greptime-docs.pages.dev |
| Branch Preview URL: | https://codex-update-outdated-grepti.greptime-docs.pages.dev |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
These new Chinese table descriptions spell the backend as postgre_store, but the supported value listed just above is postgres_store. Readers copying the condition/value while configuring PostgreSQL metadata storage would use an unrecognized backend name, so both new mentions should be corrected to postgres_store.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex address feedbacks |
|
Summary
Testing
Note: I left the existing unrelated working-tree files untouched: |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
The sample above now sets meta_schema_name = "greptime_schema" together with auto_create_schema = true, and the generated GreptimeDB config reference also reports greptime_schema as the default, so listing the default as -- is misleading. In PostgreSQL-backed metasrv deployments where the service account lacks permission to create/use that schema, operators following this table may not grant or pre-create greptime_schema and can hit startup failures even without setting the option. Please document the actual default.
The generated config reference says meta_table_name is only used for postgres_store; the MySQL metadata backend takes its database information from the DSN and does not honor this option. By adding mysql_store here, MySQL-backed metasrv users may set the value expecting the metadata table name to change, but it will be ignored. Please restrict this note to PostgreSQL unless the MySQL backend actually supports the setting.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex address feedbacks |
|
Summary
Testing
Note: I left the existing unrelated working-tree files untouched: |
|
@codex address feedbacks both zh & en version |
|
Summary
Testing
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e90be0dce8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex address feedbacks both zh & en version |
|
Summary
Testing
|
Motivation
configuration.mddocumentation (English and Chinese) up to date with newly added server and protocol options and to standardize default value formatting.flownode,jaeger,otlp) and surface new metadata/backend options required for recent runtime and kv-backend improvements.data_home, Prometheus batching, selector semantics) to reduce operator confusion.Description
enable_cors,cors_allowed_origins,prom_validation_mode,grpc.tls,mysql.keep_alive,postgres.keep_alive,prepared_stmt_cache_size, andexperimental_*flags, and OpenTelemetry/Jaeger options (jaeger,otlp,trace_ingest_chunk_size).[backend_tls]),meta_schema_name,auto_create_schema,max_recv_message_size/max_send_message_size, HTTP server defaults,max_metadata_value_size, and adjustedenable_region_failover/selector explanations to match current behavior.data_hometo storage examples, updated various default representations to a normalized format (removed extra quotes and unified code formatting) and changed several table default values and descriptions (includingpending_rows_flush_interval,max_background_*,scan_memory_limit, and WAL/selector defaults) for clarity.Testing
Codex Task