Windows build stamp: EOL-normalize the manifest the tauri-cli rewrites + keep the tree-state diagnostics (#513) - #516
Merged
Merged
Conversation
…'s dirty diagnosis (#513) A -dirty stamp is only debuggable if the log says WHAT was dirty. Before/after `git status --porcelain` around the Tauri build names the mutation (the stale lock re-lock was found by archaeology, #515; the Windows leg's residue gets named by this pair). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VdCtnsbcVyBLmc5xo5dHEX
…li rewrite isn't "dirt" (#513) The probe run's tree-state step named the Windows leg's residue: ` M src-tauri/Cargo.toml`. The Tauri CLI re-serializes the manifest during `tauri build` — byte-identical on Linux/macOS, CRLF on Windows — and the EOL-only rewrite read as a tracked modification, stamping the Windows portable -dirty while the other two legs came out clean. `text eol=lf` makes git normalize when comparing, so only a MATERIAL manifest rewrite counts as dirt, which is the distinction the stamp wants. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VdCtnsbcVyBLmc5xo5dHEX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #515 — the Windows leg still stamped
-dirtyafter the lockfile fix.The new tree-state diagnostic steps (first commit, worth keeping permanently) named the culprit in probe run 33456672440:
M src-tauri/Cargo.toml, Windows only. The Tauri CLI re-serializes the manifest duringtauri build— a semantic no-op that is byte-identical on Linux/macOS but written CRLF on Windows, where the EOL-only rewrite read as a tracked modification at stamp time.Fix:
.gitattributespinssrc-tauri/Cargo.toml text eol=lf, so git normalizes line endings when comparing and a pure EOL rewrite is not dirt — while a material manifest rewrite still is, which is exactly the distinction the build stamp wants. The file is already LF in the index, so no renormalization churn.With this, all three portables from the same dispatch should stamp the identical clean
0.4.0-dev-<hash>(linux/macOS already did on run 33353894379).🤖 Generated with Claude Code
https://claude.ai/code/session_01VdCtnsbcVyBLmc5xo5dHEX