Skip to content

fix: add missing build steps and update Node in Dockerfile#478

Merged
stewartoallen merged 1 commit intoGridSpace:rel-nextfrom
garythebat:fix/docker-build-rel-next
Apr 12, 2026
Merged

fix: add missing build steps and update Node in Dockerfile#478
stewartoallen merged 1 commit intoGridSpace:rel-nextfrom
garythebat:fix/docker-build-rel-next

Conversation

@garythebat
Copy link
Copy Markdown

Summary

Re-targeted from #476 to rel-next as requested.

  • Update base image from node:18-slim to node:22-slim (matching package.json engines requirement)
  • Add git to apt-get install (needed by npm dependencies)
  • Add webpack-ext step (builds external bundles required by esbuild)
  • Add mkdir -p src/pack (prevents race condition on clean builds)
  • Add pack-prod step (builds application bundles)
  • Reorder: build steps run before gs-app-server global install

Without these changes, the container starts but serves an incomplete app that never finishes loading - the JS bundles in src/pack/ are never built.

Test environment

  • ARM64: Raspberry Pi 4 (8GB), Pi OS Bookworm, Docker 29.4.0, Node 22
  • x86_64: Ubuntu 24.04 (Proxmox LXC), Docker 28.0.4, Node 22
  • Both: clean clone, docker compose build, verified /kiri/ loads and slices

Test plan

  • docker compose build completes without error
  • Container starts and /kiri/ returns 200
  • /lib/pack/kiri-main.js returns 200 with non-empty content
  • Slicer UI loads fully in browser
  • Import STL and slice produces gcode

- Update base image from node:18-slim to node:22-slim (matching
  package.json engines requirement)
- Add git to apt-get install (needed by npm dependencies)
- Add webpack-ext step (builds external bundles)
- Add mkdir -p src/pack (prevents race condition)
- Add pack-prod step (builds application bundles)
- Reorder: build steps before gs-app-server install

Tested on ARM64 (Raspberry Pi 4, Docker 29.4.0) and x86_64 (Ubuntu
24.04, Docker 28.0.4). Without these changes, the container starts
but serves an incomplete app that never finishes loading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants