fix: add missing build steps and update Node in Dockerfile#478
Merged
stewartoallen merged 1 commit intoGridSpace:rel-nextfrom Apr 12, 2026
Merged
Conversation
- Update base image from node:18-slim to node:22-slim (matching package.json engines requirement) - Add git to apt-get install (needed by npm dependencies) - Add webpack-ext step (builds external bundles) - Add mkdir -p src/pack (prevents race condition) - Add pack-prod step (builds application bundles) - Reorder: build steps before gs-app-server install Tested on ARM64 (Raspberry Pi 4, Docker 29.4.0) and x86_64 (Ubuntu 24.04, Docker 28.0.4). Without these changes, the container starts but serves an incomplete app that never finishes loading.
This was referenced Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-targeted from #476 to
rel-nextas requested.Without these changes, the container starts but serves an incomplete app that never finishes loading - the JS bundles in src/pack/ are never built.
Test environment
Test plan
docker compose buildcompletes without error