fix[cartesian]: actually freeze origin & domain in K-axis#2684
Merged
Conversation
This fix comes from running GFDL_1M in KJI-layout where - in NDSL - there's no extra point allocated in the vertical (to be able to directly copy the Fortran data). This commit freezes origin and `domain` (not `shape`) in the K-axis of the stencil. `shape` and `domain` agree most of the time, but can differ if - for example - the stencil is configured on `K_INTERFACE_DIM` and the field of size `K_DIM`. Depending on the combination, this can lead to out of bound reads where we were previously saved by the extra point allocated in the back (but in KJI since we don't have this point, we crash). I am not touching the horizontal axes in this commit. We probably should, but we haven't seen any crashes (probably due to the fact that we can't currently run dynamics in KJI (i.e. without the extra point)). I'd argue we should takle this in a follow-up when we also look at the "potential out of bounds" memlet warnigns that we get from dace (mainly when running dynamics).
romanc
changed the title
twicki
approved these changes
Jul 8, 2026
twicki
left a comment
twicki
left a comment
Contributor
There was a problem hiding this comment.
This is hard to parse, and we will most likely go back to clean this up when we touch the horizontal anyways.
And we know it works, so let's merge this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fix comes from running GFDL_1M in KJI-layout where - in NDSL - there's no extra point allocated in the vertical (to be able to directly copy the Fortran data).
This commit freezes origin and
domain(notshape) in the K-axis of the stencil.shapeanddomainagree most of the time, but can differ if - for example - the stencil is configured onK_INTERFACE_DIMand the field of sizeK_DIM. Depending on the combination, this can lead to out of bound reads where we were previously saved by the extra point allocated in the back (but in KJI since we don't have this point, we crash).I am not touching the horizontal axes in this commit. We probably should, but we haven't seen any crashes (probably due to the fact that we can't currently run dynamics in KJI (i.e. without the extra point)). I'd argue we should tackle this in a follow-up when we also look at the "potential out of bounds" memlet warnings that we get from dace (mainly when running dynamics).
This PR is part of cleaning up our "working branch", i.e. #2595, which accumulated a couple of changes over the last month.
Requirements
N/A
N/A