[Field dimensions] Support field masking#288
Merged
gronerl merged 97 commits intoGridTools:masterfrom Jan 28, 2021
jdahm:lower-dimensional-support
Merged
[Field dimensions] Support field masking#288gronerl merged 97 commits intoGridTools:masterfrom jdahm:lower-dimensional-support
gronerl merged 97 commits intoGridTools:masterfrom
jdahm:lower-dimensional-support
Conversation
…e if intervals overlap
…m/gt4py into bugfix/multistage-data-dependencies
Lower dimensional fixes
Skip 'test_masked_storage_gpu' test
gronerl
requested changes
Jan 25, 2021
Contributor
gronerl
left a comment
gronerl
left a comment
There was a problem hiding this comment.
In addition to the inline comments, this could need more tests, in particular also when providing arguments that are incompatible with the specification of the stencils.
…gt4py into lower-dimensional-support
gronerl
approved these changes
Jan 28, 2021
Contributor
gronerl
left a comment
gronerl
left a comment
There was a problem hiding this comment.
Thanks. I also added a test for the dimension mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Co-authored by: @eddie-c-davis
This PR supersedes #203 and is the first in a series of PR that addresses lower dimensional storages. This PR primarily allows for lower-dimensional storages to be used in stencils, both in the annotations and in execution with storages constructed using the
maskargument. This:maskA follow-up PR will add back the storage reduction pass.
To do: