Skip to content

While loops in old backends#410

Merged
DropD merged 32 commits intoGridTools:masterfrom
jdahm:while-loop
Jun 18, 2021
Merged

While loops in old backends#410
DropD merged 32 commits intoGridTools:masterfrom
jdahm:while-loop

Conversation

@jdahm
Copy link
Copy Markdown
Contributor

@jdahm jdahm commented Apr 29, 2021

Description

Adds while loops to the gtscript frontend and old backends.

Blocked by #396.

To do:

  • Integration test

@jdahm jdahm changed the title While loop in AST While loops in old backends Apr 29, 2021
@jdahm jdahm marked this pull request as ready for review May 5, 2021 15:32
@DropD
Copy link
Copy Markdown
Contributor

DropD commented Jun 17, 2021

bors try

@bors
Copy link
Copy Markdown

bors Bot commented Jun 17, 2021

try

Merge conflict.

@DropD
Copy link
Copy Markdown
Contributor

DropD commented Jun 18, 2021

bors try

bors Bot added a commit that referenced this pull request Jun 18, 2021
Copy link
Copy Markdown
Contributor

@DropD DropD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close to approval, only two minor things.

Comment thread src/gt4py/frontend/gtscript_frontend.py Outdated
Comment thread src/gt4py/backend/python_generator.py Outdated
@bors
Copy link
Copy Markdown

bors Bot commented Jun 18, 2021

try

Build succeeded:

@DropD DropD merged commit 634a416 into GridTools:master Jun 18, 2021
@DropD DropD deleted the while-loop branch June 18, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants