Merged
Conversation
Contributor
|
Thanks, for linking again the hackmd document. Forgot about that. Let's discuss GridTools/concepts#50 before I continue my review here. |
havogt
requested changes
Jan 26, 2022
Contributor
|
bors try |
havogt
requested changes
Feb 9, 2022
Contributor
havogt
left a comment
havogt
left a comment
There was a problem hiding this comment.
Please add a regression test for nested while loops. I think then it's good to go.
tryBuild failed: |
Contributor
Will do! Technically we should merge #628 first. |
Contributor
|
bors try |
tryBuild failed: |
Contributor
|
Build did not fail. It timed out waiting to start... |
havogt
approved these changes
Feb 17, 2022
Contributor
|
bors try |
tryBuild failed: |
Contributor
|
bors try |
tryBuild succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
whileloop construct in the GTC toolchain and relies on PR #410 for the frontend implementation.Blocked by #628.