Clean up gtc:numpy backend and fix issues#628
Merged
jdahm merged 14 commits intoGridTools:masterfrom Feb 18, 2022
jdahm:numpy-masks-on-scalars
Merged
Clean up gtc:numpy backend and fix issues#628jdahm merged 14 commits intoGridTools:masterfrom jdahm:numpy-masks-on-scalars
jdahm merged 14 commits intoGridTools:masterfrom
jdahm:numpy-masks-on-scalars
Conversation
jdahm
changed the title
jdahm
changed the title
jdahm
changed the title
Contributor
Author
|
bors try |
jdahm
added a commit
to eddie-c-davis/gt4py
that referenced
this pull request
Feb 7, 2022
Contributor
Author
|
The daint tests passed, there was just a problem propagating that back to GitHub here. |
tryTimed out. |
egparedes
reviewed
Feb 11, 2022
Contributor
egparedes
left a comment
egparedes
left a comment
There was a problem hiding this comment.
I have some comments but it looks good to me. Additionally, I think someone else with a deeper knowledge of the gtc toolchain should review the PR.
egparedes
reviewed
Feb 16, 2022
Contributor
egparedes
left a comment
egparedes
left a comment
There was a problem hiding this comment.
Almost ready from my side, just a couple of small issues.
Contributor
Author
|
bors try |
tryBuild succeeded: |
egparedes
approved these changes
Feb 18, 2022
Contributor
egparedes
left a comment
egparedes
left a comment
There was a problem hiding this comment.
It looks good from my side. It would be great if someone else with a deeper knowledge of GTC would have time to review it today, but it's not a strict requirement so I'm approving the PR. @jdahm can merge in the evening if there are no comments from anyone else.
Contributor
Author
|
bors try |
tryBuild succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rewrites the numpy backend to resolve a number of outstanding bugs. The biggest changes are:
GT_CACHE_PYTEST_DIRenv var to control pytest dir. This is useful for debugging, because breakpoints can be set in the generated Python code.Resolves #632.
Resolves #621.
To do:
oir_to_npirtests.StencilExtentComputerfor cleaner dependency chain.