Bring back the component-layer rules the utilities fix dropped - #400
Merged
Conversation
GRYT-858 stopped importing @gryt/ui/styles.css and scanned dist for class names instead, which fixed two utilities layers fighting. It also dropped every rule in the library's components layer, because those are not utilities and scanning cannot recover them. So the welcome dialog's message bubble has been a square with no padding, and the composer, the conversation item, the indeterminate progress bar and the label hover have been running without their rules too. @gryt/ui ships those separately now. This imports them, with no utilities layer attached, so GRYT-858 stays fixed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The version that ships components.css is out, so the lockfile can name it. CI installs with --frozen-lockfile, which fails on a lockfile that still resolves ^0.26.0 to 0.25.1. Verified against the published package rather than a local build: .gryt-message-bubble is in a loaded stylesheet again, and the welcome bubble computes border-radius 28px and padding 12px 16px. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on
@gryt/ui0.26.0. Draft until that's released, because theimport doesn't resolve before it.
Ships with Gryt-chat/ui#161.
What broke
Sivert: "seems the welcome to gryt modal got changed? it has a square
background on the text now?"
It did. GRYT-858 replaced
@import "@gryt/ui/styles.css"with@source "../node_modules/@gryt/ui/dist"to stop two utilities layers fighting,which was right. But
@sourceregenerates utilities, and the library's@layer componentsrules are hand-written, so they went with it. Measured inthe running client:
.gryt-message-bubblecomputesborder-radius: 0pxandpadding: 0px, and neither it nor.gryt-composeris in any loaded stylesheet.Five components lost their rules. The bubble is the one you can see.
What changed
One import of
@gryt/ui/components.css, which is the components layer with noutilities attached, plus the dependency bump that provides it.
What I checked
Ran the client with the new file dropped into
node_modules. The bubblecomputes
border-radius: 28pxandpadding: 12px 16px, and the dialog reads asa message again rather than a rectangle.
What to look at
The dependency bump.
^0.25.1won't take 0.26.0, so it has to move, and thiscan't merge before that release exists.
🤖 Generated with Claude Code