cfitsio include not found: missing CFLAGS

[DerPit]

I try to compile PI on an opensuse Tumbleweed system. It fails compiling src/widgets/controls/controlwidget.cpp:
/usr/include/CCfits/CCfits.h:13:10: fatal error: fitsio.h: No such file or directory

Reason is the make call does not use the cfitsio/ccfits CFLAGS "-D_REENTRANT -I/usr/include/cfitsio"
Same happens for src/image_handlers/output_writers/imagefilewriter.cpp

[GuLinux]

Hi, thanks for the report.

A few dependencies are unfortunately not provided by existing cmake files, so I took a shortcut hardcoding the includes/libraries in the CMakeLists file. I'll try having a look this weekend.
Cheers,
Marco

[GreatAttractor]

I tried it on Tumbleweed. Finding of dependencies is in place, but it turned out this returns wrong path (in cmake/find_dependencies.cmake):

include_directories(${CFITSIO_INCLUDEDIR})

but this is OK:

include_directories(${CFITSIO_INCLUDE_DIRS})

(Both work fine on Fedora.)

I didn't create a PR yet, as there are more errors (incomplete type QButtonGroup).

[DerPit]

Yes, with that change it does compile correctly here, thanks!
I do not get any further errors though (this is TW 20180530; I'm not compiling drivers simulator, qhy, flycapture2)

[GreatAttractor]

I'm glad it works for you. Mine is TW 20180606. I'll also check the remaining drivers.

[DerPit]

So likely a change in QT? 0606 did switch QT 5.10->5.11