Update GunshellCommand.java #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.hasPermission requires a player. sender is not a player. new variable player type Player filled with sender converted to a Player with (Player) used to check the permission.
mappings changed. https://mappings.dev/1.21.5/ https://mappings.dev/1.21.8/ https://mappings.dev/1.21.9/ also implementation should be isolated with the specific require dependencies to compile. 1.21.5 (1.21.R4) uses the spigot-api for 1.21.5 and the spigot 1.21.5 1.21.8 (1.21.R5) uses the spigot-api for 1.21.8 and the spigot 1.21.8 for future notes 1.21.9 (1.21.R6) uses the spigot-api for 1.21.9 and the spigot 1.21.9 1.21.11(in theory as we have snapshots for it)(1.21.R7) will use the spigot-api for 1.21.11 and the spigot 1.21.11
Jazzkuh
reviewed
Oct 13, 2025
Member
There was a problem hiding this comment.
This has literally zero effect. Fyi, permission checks also work on CommandSenders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.hasPermission requires a player.
sender is not a player.
new variable player type Player filled with sender converted to a Player with (Player) used to check the permission.