Skip to content

Update GunshellCommand.java #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Firesped wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update GunshellCommand.java #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c9544d
Update GunshellCommand.java
Firesped Oct 13, 2025
1cfcfee
Update v1_21_8.java
Firesped Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/jazzkuh/gunshell/common/commands/GunshellCommand.java
View file
Open in desktop
Copy link
Member

@Jazzkuh Jazzkuh Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has literally zero effect. Fyi, permission checks also work on CommandSenders.

Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ public class GunshellCommand extends ExtendedAnnotationCommand {
@Main
@Alias("gs")
public void main(CommandSender sender) {
Player player = (Player) sender;
if (!sender.hasPermission("gunshell.commands.gunshell")) {
this.onInfo(sender);
return;
Expand Down Expand Up @@ -143,4 +144,4 @@ public void onGetMelee(CommandSender sender, GunshellMelee melee, int durability
player.getInventory().addItem(melee.getItemStack(durability));
MessagesConfig.SUCCESSFULLY_ADDED_MELEE_TO_INVENTORY.get(sender);
}
}
}
6 changes: 3 additions & 3 deletions src/main/java/com/jazzkuh/gunshell/compatibility/versions/v1_21_8.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@ public String getRayTraceResult(Player player, int range) {
@Override
public void showEndCreditScene(Player player) {
PacketPlayOutGameStateChange gameStateChange = new PacketPlayOutGameStateChange(PacketPlayOutGameStateChange.e, 1f);
((CraftPlayer) player).getHandle().f.a(gameStateChange);
((CraftPlayer) player).getHandle().g.a(gameStateChange);
}

@Override
public void showDemoMenu(Player player) {
PacketPlayOutGameStateChange gameStateChange = new PacketPlayOutGameStateChange(PacketPlayOutGameStateChange.f, 0f);
((CraftPlayer) player).getHandle().f.a(gameStateChange);
((CraftPlayer) player).getHandle().g.a(gameStateChange);
}

@Override
Expand All @@ -81,7 +81,7 @@ public void sendPumpkinEffect(Player player, boolean forRemoval) {
itemStack = XMaterial.CARVED_PUMPKIN.parseItem();
}

craftPlayer.getHandle().f.a(new PacketPlayOutSetSlot(0, 0, 5,
craftPlayer.getHandle().g.a(new PacketPlayOutSetSlot(0, 0, 5,
CraftItemStack.asNMSCopy(itemStack)));
}

Expand Down