Skip to content

Add HLKX package merge support#84

Open
elizashurov wants to merge 1 commit into
HCK-CI:masterfrom
elizashurov:RHELMISC-35996
Open

Add HLKX package merge support#84
elizashurov wants to merge 1 commit into
HCK-CI:masterfrom
elizashurov:RHELMISC-35996

Conversation

@elizashurov

Copy link
Copy Markdown
Contributor

Add a new mergehlkxpackages command that merges two or more HLKX packages into one using the HLK API. Also re-add drivers and supplemental files after the merge, since Merge() alone does not copy them.

@elizashurov elizashurov requested a review from kostyanf14 July 9, 2026 07:14

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces functionality to merge multiple HLKX packages into a single package. It adds the merge_hlkx_packages method in Ruby and the corresponding mergehlkxpackages PowerShell function, which handles merging and re-adding extracted drivers and supplemental files. Feedback recommends validating input and escaping single quotes in the Ruby method to prevent command injection, as well as ensuring that $PackageWriter is properly disposed of in the PowerShell script's finally block to avoid resource leaks.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/rtoolsHCK.rb
Comment thread tools/toolsHCK.ps1
Add a new mergehlkxpackages command that merges two or more HLKX
packages into one using the HLK API. Also re-add drivers and
supplemental files after the merge, since Merge() alone does not
copy them.

Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant