Enable error printing for internal data filters - #6539
Merged
Conversation
fortnern
requested review from
glennsong09,
jhendersonHDF,
mattjala and
vchoi-hdfgroup
as code owners
July 20, 2026 00:14
Contributor
mattjala
reviewed
Jul 20, 2026
| /*------------------------------------------------------------------------- | ||
| * Function: test_filter_error_msg | ||
| * | ||
| * Purpose: Tests that the library properly fails when the buffer size |
Contributor
There was a problem hiding this comment.
Looks like this comment is a leftover copy from test_bad_buf_size
mattjala
reviewed
Jul 20, 2026
| }}; | ||
| static const char *filter_error_msg_msg = | ||
| "Hello I am a unique error message written for the test_filter_error_msg test in dsets.c"; | ||
| bool enable_error_msg; |
Contributor
There was a problem hiding this comment.
Since this is only used in this file, it should probably be declared static. Same goes for error_msg_found, dsets_h5zregister_direct, and dsets_h5zunregister_direct.
mattjala
reviewed
Jul 20, 2026
for set_local for internal filters, update comments.
Member
Author
|
Thanks Matt, I've addressed the comments. |
Member
Author
|
ROS3 and nvhpc failures are unrelated to this PR |
lrknox
approved these changes
Jul 21, 2026
mattjala
approved these changes
Jul 21, 2026
github-project-automation
Bot
moved this from To be triaged
to Done
in HDF5 - TRIAGE & TRACK
scivision
pushed a commit
to scivision/hdf5
that referenced
this pull request
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent pausing the error stack when the filter is mandatory and there is no callback, and prevent saving/restoring the error stack when calling a library internal filter. This currently has two limitations:
I will continue investigating these cases.
Fixes #6194