Skip to content

Conversation

@knoepfel
Copy link
Contributor

@knoepfel knoepfel commented May 6, 2022

This PR solves #626 and it is a first step toward fixing issue #639.The reason for the blocking is that all channels were brought online before the server's serve_forever() call was made. This PR calls serve_forever() much earlier and starts the channels using a separate thread. This solves one issue but it the de-client --status call still hangs even after serve_forever() has been called.

@knoepfel knoepfel changed the title Do not block during de-client --status during startup Do not block de-client --status during startup May 6, 2022
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #648 (8cc99be) into master (f4dc7da) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
- Coverage   97.45%   97.36%   -0.09%     
==========================================
  Files          49       49              
  Lines        2943     2960      +17     
  Branches      470      471       +1     
==========================================
+ Hits         2868     2882      +14     
- Misses         50       53       +3     
  Partials       25       25              
Flag Coverage Δ
python-3.10 97.19% <100.00%> (-0.06%) ⬇️
python-3.6 96.91% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../decisionengine/framework/engine/DecisionEngine.py 93.11% <100.00%> (-0.34%) ⬇️
...c/decisionengine/framework/engine/SourceWorkers.py 98.51% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4dc7da...8cc99be. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented May 6, 2022

This pull request introduces 1 alert when merging 5307958 into f4dc7da - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

jcpunk
jcpunk previously approved these changes May 11, 2022
@knoepfel knoepfel changed the title Do not block de-client --status during startup Fix systemctl stop time delay May 11, 2022
@mambelli mambelli merged commit c9c7cb3 into HEPCloud:master May 12, 2022
@knoepfel knoepfel deleted the no-block-status branch May 12, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants