[Issue #11727] Move sam.gov client to grants-shared - 1st PR - #6
Merged
Conversation
hao10282025-sudo
marked this pull request as ready for review
August 19, 2026 17:54
chouinar
reviewed
Aug 19, 2026
chouinar
left a comment
chouinar
left a comment
Collaborator
There was a problem hiding this comment.
One minor change suggested, can you update the package version so after you merge this, we can publish it?
Comment on lines
+46
to
+48
| # These fields were removed from the model | ||
| # assert response.content_type == "application/zip" | ||
| # assert response.sensitivity == SensitivityLevel.PUBLIC |
Collaborator
There was a problem hiding this comment.
I know this was in what you copied over, but can you remove them?
Collaborator
Author
There was a problem hiding this comment.
ok updated
Collaborator
Author
yes bumped with minor version |
chouinar
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 11727
Changes proposed
https://github.com/HHS/simpler-grants-gov/tree/main/api/src/adapters/sam_gov
We want to move the sam.gov client to grants shared from the simpler repo as we'll soon need to add new implementations to this client for new sam.gov endpoints. The client should be pretty self-contained and able to move.
Note we do not need to move the logic that uses the client - which fetch and process sam.gov extracts. While that might eventually be something we want to do on grants management, that would be quite complex to move at this time.
Context for reviewers
This is the 1st PR for task #11727, for adding the sam.gov client self to the grants-shared solution.
There will be 2nd PR to updating importing/reference from simpler grants solution.
Validation steps