Language Overhaul by 3gf8jv4dv · Pull Request #3287 · HMCL-dev/HMCL

3gf8jv4dv · 2024-09-12T14:10:22Z

Continuation of #3150.

This PR makes important quality improvements to the language used by the main users of HMCL (Chinese and some English users). Due to my limited ability, for other languages, there are only minor revisions. If I get a chance later, I might overhaul other languages.

I would appreciate it if you could take the time to review this PR.

Changelog

Major revisions to English and Chinese variants
Minor revisions to Spanish, Japanese and Russian
For All Languages: Unified the format of all line breaks, and it is now easier to read in plain text
For All Languages: Optimized homepage hints to make them look cleaner
For All Languages: Adjusted the order of translation keys for Curse, Modrinth and game.crash.reason
For All Languages: Fixed some wrong key names and some irrelevant translations
For English and Chinese variants: Unified most terms to avoid confusion
For English and Chinese variants: Changed some terminology to make it consistent with the current situation and align with the terminology of some authoritative websites
For English and Chinese variants: Optimized some translated descriptions to make them more accurate and easier to understand
For English and Chinese variants: Supplemented all translations, now the number of translation keys should be consistent for English and Chinese variants
For GitHub Action: Removed unnecessary translation checks
For Launcher: Added category items above "Settings → Global Settings"
For Launcher: Capitalized the text above the sidebar
For Launcher: Separated mod update channel from game update channel (Why do so many places that should be translated differently use the same key...)
For Launcher: Unified launcher update channel names
...

Check out all commits or the Files changed section for all changes.

Format all language files

Fix some key typos

Fix other language translations mixed in ja and ru

Overhaul of Chinese (Simplified, Mainland China)

Overhaul of English (United States)

Revise and unify some links

- Overhaul of Chinese (Simplified, Mainland China) - Minor revision of English (United States)

Various revisions for: - English (United States) - Chinese (Simplified, Mainland China) Several translations port from #3129.

Misc revisions.

- Overhaul of Chinese (Traditional, Taiwan) - Major revisions of English (United States) and Chinese (Simplified, Mainland China) - Various revisions of other languages - Curse & Modrinth translation key order adjustment - Fix CheckTranslations - Remove unnecessary translation checks

Redesign homepage hint style for all languages.

Various revisions of English and Chinese variants.

Various revisions of various languages.

- Add the category item `Game` above `Global Settings` - Some translation revisions of Chinese (Traditional, Taiwan) - Optimize translation related to World page - Various revisions

Capitalize text above the sidebar line

- Optimize the Russian partial translation so that it can be fully displayed in the UI - Optimize the loader offline installer description to make it shorter - Various revisions

3gf8jv4dv · 2024-09-13T08:41:58Z

@burningtnt @Glavo @zkitefly or others who are interested in this...

It is now almost complete, your review is greatly needed. You can check the Files changed section, or download a build from GHA to test it.

Minor revisions of Chinese variants.

zkitefly · 2024-09-14T22:14:44Z

build.gradle.kts

这个检测还是有必要的，以防有人输错

I think a more appropriate form is to give a reminder in the form of review/suggestion when a user submits a related PR. But let’s see what others think.

HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties

Apply suggestions from zkitefly (semicolon) Co-authored-by: Zkitefly <2573874409@qq.com>

Apply suggestion from hejiehao (terms upper/lower case) Co-authored-by: hejiehao <hejiehao12@126.com>

Apply suggestions from zkitefly (你/您) Co-authored-by: Zkitefly <2573874409@qq.com>

Misc revisions of Chinese (Simplified, Mainland China)

- Fix a mistake I made - Misc revisions

- Revert changes of `version.game.snapshot(s)` - Improve translation of `version.game.old` in Chinese variants - Improve translation of `install.failed.optifine_conflict` - Improve spacing style of slashes - Improve some punctuation - Fix some translations of Chinese variants

Various revisions of English and Chinese variants

Oops...

Various revisions of English

- Fix directory/folder terminology inconsistency - Various revisions

Various revisions

Fix line wrapping in some error messages

Oops...

3gf8jv4dv · 2024-09-23T16:02:43Z

Now the revision of English and Chinese is basically completed (REALLY).

Next plan:

Try to fix some UI translation issues (such issues require code changes to resolve)
Continue to review and revise English and Chinese
Try to overhaul the other three languages
Add several new languages (if I still have time and energy)

In the meantime, any reviews are still welcome.

- Unify brackets in Chinese language - Various revisions

Fix proxy `host` and `port` translation halignment being different from other translations

Revise Microsoft login hint of Chinese language to be consistent with actual content displayed on Microsoft website

- For Chinese, rewrite Microsoft login hint to make it clean and clear - Remove some useless translation keys - For `game.crash.reason.graphics_driver`, remove the content about OpenGL, since OpenGL is now used by default, this is not needed

Various revisions

- Emphasis on "版本隔离" in the Mainland Chinese variant - Fix some English grammar — it should be more perfect now

Minor revision of Traditional Chinese

Various revisions

misc

oops...

Various revisions

Revision of Chinese (Traditional, Taiwan)

Glavo · 2024-10-13T16:16:30Z

I think this is a very large PR and it's difficult to review and give feedback. Can you split it into multiple smaller PRs?

3gf8jv4dv · 2024-10-13T23:36:43Z

I think this is a very large PR and it's difficult to review and give feedback. Can you split it into multiple smaller PRs?

OK. I will do it later.

3gf8jv4dv · 2024-10-14T10:50:20Z

Changes involving the code have been ported to the following PRs:

Regarding language revision, i18n key revision and line wrapping optimization, I am still working hard on porting...

cc @Glavo

3gf8jv4dv added 13 commits September 7, 2024 15:02

Revise 1

651b4b0

Format all language files

Revise 2

e129d65

Fix some key typos

Revise 3

efebd16

Fix other language translations mixed in ja and ru

Revise 4

09c7509

Overhaul of Chinese (Simplified, Mainland China)

Revise 5

a2bde8d

Overhaul of English (United States)

Revise 6

9c12f8f

Revise and unify some links

Revise 7

82389e8

- Overhaul of Chinese (Simplified, Mainland China) - Minor revision of English (United States)

Revise 8

a27cb88

Various revisions for: - English (United States) - Chinese (Simplified, Mainland China) Several translations port from #3129.

Revise 9

a8e037a

Misc revisions.

Revise 11

c760a90

Redesign homepage hint style for all languages.

Revise 12

1560a7c

Various revisions of English and Chinese variants.

Revise 13

11379fe

Various revisions of various languages.

burningtnt mentioned this pull request Sep 12, 2024

PR Collection 开发进展 burningtnt/HMCL#9

Closed

3gf8jv4dv added 2 commits September 13, 2024 12:35

Revise 14

6078dba

- Add the category item `Game` above `Global Settings` - Some translation revisions of Chinese (Traditional, Taiwan) - Optimize translation related to World page - Various revisions

Revise 15

9876bd7

Capitalize text above the sidebar line

3gf8jv4dv mentioned this pull request Sep 13, 2024

Capitalize text above the sidebar line #3255

Closed

Revise 16

c89500c

- Optimize the Russian partial translation so that it can be fully displayed in the UI - Optimize the loader offline installer description to make it shorter - Various revisions

Revise 17

3f13738

Minor revisions of Chinese variants.

zkitefly reviewed Sep 14, 2024

View reviewed changes

3gf8jv4dv and others added 9 commits September 15, 2024 19:22

Revise 18

4a79187

Apply suggestions from zkitefly (semicolon) Co-authored-by: Zkitefly <2573874409@qq.com>

Revise 19

f9c2848

Apply suggestion from hejiehao (terms upper/lower case) Co-authored-by: hejiehao <hejiehao12@126.com>

Revise 20

61005bf

Apply suggestions from zkitefly (你/您) Co-authored-by: Zkitefly <2573874409@qq.com>

Revise 21

5da5e5c

Misc revisions of Chinese (Simplified, Mainland China)

Revise 22

d04de4e

- Fix a mistake I made - Misc revisions

Revise 23

da004db

- Revert changes of `version.game.snapshot(s)` - Improve translation of `version.game.old` in Chinese variants - Improve translation of `install.failed.optifine_conflict` - Improve spacing style of slashes - Improve some punctuation - Fix some translations of Chinese variants

Revise 24

7dd9835

Various revisions of English and Chinese variants

Revise 25

39cf163

Oops...

Revise 26

22a55c3

Various revisions of English

3gf8jv4dv added 4 commits September 23, 2024 20:39

Revise 37

3e19c9e

- Fix directory/folder terminology inconsistency - Various revisions

Revise 38

0b0d36c

Various revisions

Revise 39

d60f6bb

Fix line wrapping in some error messages

Revise 40

60fbe44

Oops...

3gf8jv4dv added 18 commits September 24, 2024 16:55

Revise 41

21ff98f

- Unify brackets in Chinese language - Various revisions

Revise 42

1d13030

Fix proxy `host` and `port` translation halignment being different from other translations

Revise 43

8b07b48

Revise Microsoft login hint of Chinese language to be consistent with actual content displayed on Microsoft website

Revise 44

ff3c106

- For Chinese, rewrite Microsoft login hint to make it clean and clear - Remove some useless translation keys - For `game.crash.reason.graphics_driver`, remove the content about OpenGL, since OpenGL is now used by default, this is not needed

Revise 45

e888172

Various revisions

Revise 46

b48b381

Various revisions

Revise 47

2ff343e

- Emphasis on "版本隔离" in the Mainland Chinese variant - Fix some English grammar — it should be more perfect now

Revise 48

86216fb

Minor revision of Traditional Chinese

Revise 49

a28f050

Various revisions

Revise 50

003bef4

misc

Revise 51

7f2d60e

oops...

Revise 52

0ca2325

Various revisions

Merge branch 'main' into lang-revision

6cced61

Merge branch 'main' into lang-revision

90edecc

Merge branch 'main' into lang-revision

272b7ea

Merge branch 'main' into lang-revision

15c31cf

Revise 57

b9b3066

Revision of Chinese (Traditional, Taiwan)

Merge branch 'main' into lang-revision

e966500

Glavo closed this Oct 14, 2024

3gf8jv4dv mentioned this pull request Oct 19, 2024

Revise zh_TW part 4 #3359

Merged

3gf8jv4dv deleted the lang-revision branch October 25, 2024 04:53

3gf8jv4dv mentioned this pull request Dec 9, 2024

[I18n zh_cn] "测试版" vs "开发版"? "快照版" vs "预览版"? #3489

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Language Overhaul#3287

Language Overhaul#3287
3gf8jv4dv wants to merge 58 commits intoHMCL-dev:mainfrom
3gf8jv4dv:lang-revision

3gf8jv4dv commented Sep 12, 2024 •

edited

Loading

Uh oh!

3gf8jv4dv commented Sep 13, 2024

Uh oh!

zkitefly Sep 14, 2024

Uh oh!

3gf8jv4dv Sep 15, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

3gf8jv4dv commented Sep 23, 2024 •

edited

Loading

Uh oh!

Glavo commented Oct 13, 2024

Uh oh!

3gf8jv4dv commented Oct 13, 2024

Uh oh!

3gf8jv4dv commented Oct 14, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

3gf8jv4dv commented Sep 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Uh oh!

3gf8jv4dv commented Sep 13, 2024

Uh oh!

zkitefly Sep 14, 2024

Choose a reason for hiding this comment

Uh oh!

3gf8jv4dv Sep 15, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

3gf8jv4dv commented Sep 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Glavo commented Oct 13, 2024

Uh oh!

3gf8jv4dv commented Oct 13, 2024

Uh oh!

3gf8jv4dv commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

3gf8jv4dv commented Sep 12, 2024 •

edited

Loading

3gf8jv4dv commented Sep 23, 2024 •

edited

Loading

3gf8jv4dv commented Oct 14, 2024 •

edited

Loading