Skip to content

Enhance renderer selection based on game version - #6316

Merged
Glavo merged 1 commit into
HMCL-dev:mainfrom
Glavo:renderer
Jul 5, 2026
Merged

Enhance renderer selection based on game version#6316
Glavo merged 1 commit into
HMCL-dev:mainfrom
Glavo:renderer

Conversation

@Glavo

@Glavo Glavo commented Jul 5, 2026

Copy link
Copy Markdown
Member

No description provided.

@Glavo

Glavo commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces dynamic graphics API selection and support checks based on the Minecraft game version. Specifically, it updates GameSettings and GraphicsAPI to determine the default graphics API (OpenGL or Vulkan) depending on the game version number, with Vulkan being the default only for versions between 26.2-snapshot-1 and 26.2. It also updates the UI in GameSettingsPage to dynamically show or hide OpenGL and Vulkan configuration options based on version compatibility. There are no review comments, so I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Glavo
Glavo merged commit 1c0e506 into HMCL-dev:main Jul 5, 2026
2 checks passed
@Glavo
Glavo deleted the renderer branch July 5, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant