Feat: Animate menu button arrow counter-clockwise on popup display#6344
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an animated rotation effect for the version switch menu button's arrow icon when the game list popup is opened and closed. To support this, a new showAndGetPopup method was added to GameListPopupMenu to return the popup instance. The review feedback suggests using FXUtils.playAnimation to prevent animation conflicts on the arrow graphic when rapidly toggling the menu, and refactoring the existing show method in GameListPopupMenu to delegate to the new showAndGetPopup method to avoid code duplication.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a rotation animation for the version switch menu button when its popup is shown and hidden, refactoring GameListPopupMenu to return the popup instance. The review feedback suggests removing redundant arm() and disarm() calls on the button inside the action handler, and respecting user animation preferences by checking if animations are enabled before playing the transitions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a rotation animation for the version switch button's icon when its popup menu is opened and closed. To support this, GameListPopupMenu was refactored to return the popup instance via a new showAndGetPopup method. The review feedback suggests adding a defensive null check on menuButton.getGraphic() to prevent potential NullPointerExceptions, and optimizing the code when animations are disabled by directly calling Node.setRotate() instead of instantiating a RotateTransition.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
2 participants
为启动面板的菜单按钮图标添加了旋转动画
特性
关闭动画设置适配。实况
_20260709_022537.mp4