Skip to content

完善游戏设置页面帮助文本 - #6415

Merged
Glavo merged 5 commits into
HMCL-dev:mainfrom
Glavo:text
Jul 15, 2026
Merged

完善游戏设置页面帮助文本#6415
Glavo merged 5 commits into
HMCL-dev:mainfrom
Glavo:text

Conversation

@Glavo

@Glavo Glavo commented Jul 15, 2026

Copy link
Copy Markdown
Member

No description provided.

@Glavo

Glavo commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ab5f06a20a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

settings.type.global.preset.default=Use Default Preset
settings.type.global.preset.duplicate_name=Preset name already exists
settings.type.global.preset.help=A game settings preset manages a set of game settings that you can adjust on this page.\n\
All instances inherit game settings from the current preset by default. You can override specific settings on the instance game settings page.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Badge Correct preset inheritance tooltip

For an instance with no explicit parent, GameSettingsPage#getExplicitParentGameSettings() falls back to SettingsManager.getDefaultGameSettingsPresetOrCreate(), not whichever preset is currently selected for editing. When the user is viewing a non-default preset, this tooltip says all instances inherit the current preset by default, which can lead them to edit the wrong preset; please say instances inherit the default preset unless explicitly assigned.

Useful? React with 👍 / 👎.

Glavo added 2 commits July 15, 2026 21:04
- Show basic settings before preset management for a clearer flow
- Update preset help text to refer to settings below
@Glavo
Glavo merged commit 9866d88 into HMCL-dev:main Jul 15, 2026
2 checks passed
@Glavo
Glavo deleted the text branch July 15, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant