fix: 切换版本隔离设置后自动刷新其他子页面 功能失效#6468
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates imports in GameSettingsPage.java and adds code to fire a WorkingDirChangedEvent when toggling the instance isolation button. The reviewer suggested a more robust and centralized approach: instead of manually firing the event in bindInstanceIsolationButton, a listener should be added to the resolved running directory path (textProperty) in bindRunningDirectoryProperty to handle all scenarios where the working directory changes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
|
||
| textProperty.addListener((observable, oldValue, newValue) -> { | ||
| if (!Objects.equals(oldValue, newValue)) { | ||
| FXUtils.runInFX(() -> fireEvent(new VersionPage.WorkingDirChangedEvent())); |
There was a problem hiding this comment.
为什么要 runInFX？不要到处乱放 runInFX，这些属性变化本来就发生在 FX 线程上，不应该用 runInFX。
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f65b7c8ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
#6468 Co-authored-by: 辞庐 <109708109+CiiLu@users.noreply.github.com>
2 participants
No description provided.