优化 32 位平台自动分配内存策略 - #6641
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f22a831fb5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| long memoryAllocated; | ||
| if (Boolean.TRUE.equals(autoMemory)) { | ||
| memoryAllocated = HMCLGameRepository.getAutoAllocatedMemory(memoryStatus.available()); | ||
| memoryAllocated = HMCLGameRepository.getAutoAllocatedMemory(memoryStatus.available(), Platform.SYSTEM_PLATFORM); |
There was a problem hiding this comment.
On a 64-bit host when an instance is configured to use a 32-bit Java runtime, this passes the 64-bit system platform, so the settings page displays the uncapped automatic allocation while getLaunchOptions uses java.getPlatform() and actually caps -Xmx at 768 MiB. Use the effective selected Java platform here as well so the displayed allocation matches what the game receives.
Useful? React with 👍 / 👎.
1 participant
No description provided.