Skip to content

修复导出mrpack时,已禁用模组有关bug - #6830

Merged
Glavo merged 2 commits into
HMCL-dev:mainfrom
Xirren:fix/modrinth-export-disabled-mod-path
Sep 6, 2026
Merged

修复导出mrpack时,已禁用模组有关bug#6830
Glavo merged 2 commits into
HMCL-dev:mainfrom
Xirren:fix/modrinth-export-disabled-mod-path

Conversation

@Xirren

@Xirren Xirren commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

fix 已禁用模组路径使用反斜杠的问题
fix 获取移除后缀路径时,潜在的实际改动文件的副作用

enableMod 返回的 Path 在 Windows 上使用反斜杠分隔符,
导致 manifest 中禁用模组的 path 与其他文件不一致。
不再调用 enableMod 来间接获取去掉 .disabled 后缀的文件名,
避免导出过程中对实例目录外文件的意外重命名。
@github-actions github-actions Bot added the 1+ label Sep 6, 2026
@Glavo

Glavo commented Sep 6, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-06T12:15:56.495057Z df2c02f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Glavo
Glavo merged commit 1da8c8d into HMCL-dev:main Sep 6, 2026
3 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: df2c02f6eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants