Dockerfile: use corepack + skip Cypress binary to stabilise Smoke Test build#737
Merged
Conversation
solved the docker build and smoke test which it was having
Member
|
Thank you so much @XPE-7! This is really great. |
Contributor
Author
|
Thank you, @EdwardMoyse glad I could help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker image used by the Smoke Test workflow was failing during yarn install because Cypress attempted to fetch and set up its native binary in an environment where we don’t actually run e2e tests. This PR adjusts the Dockerfile to make that build deterministic and lean.
Background
After PR #736 (scoping Jest/Cypress TS types) was merged, the fresh build on main re-ran the Smoke Test and exposed this long‑standing issue: Cypress’ install step isn’t needed for the static docs build and sometimes breaks on missing native libraries. The workflow itself (ref 16bd6fa) only builds and curls the served site—no Cypress commands are executed.
Changes
Rationale
We only need the compiled static site for the Smoke Test; pulling in the Cypress binary adds no value and introduces avoidable fragility. Using Corepack avoids accidentally invoking a legacy global Yarn version.
Testing
Locally built the image:
Received 200 OK and site served as expected. Container logs clean (no Cypress native build attempts).
@EdwardMoyse pleas verify and merge this and let me know any further changes in it.