Skip to content

fix: hide labels during animations until event objects fully appear#741

Merged
EdwardMoyse merged 5 commits into
HSF:mainfrom
Shivansh1205:fix-hide-labels-during-animation
Dec 5, 2025
Merged

fix: hide labels during animations until event objects fully appear#741
EdwardMoyse merged 5 commits into
HSF:mainfrom
Shivansh1205:fix-hide-labels-during-animation

Conversation

@Shivansh1205
Copy link
Copy Markdown
Contributor

Summary

This PR fixes an issue where labels were appearing too early during animations,
causing them to overlap with partially-drawn tracks, jets, hits, and other event
objects. The labels now remain hidden during the animation and correctly reappear
once all animated objects are fully visible.

Problem

Previously, the Labels group was always visible, even while geometry drawRanges,
track propagation, and event-generation animations were still in progress.
This resulted in:

  • Labels floating in empty space before the objects were drawn
  • Visual clutter during track growth and hit expansion
  • Poor visual coherence during preset camera animations and clipping animations

Fix

Labels are now toggled via visibility control during animation:

  • Hidden at animation start
  • Shown again when animation finishes

This behavior is applied consistently in all animation entrypoints:

  • animateEvent
  • animateEventWithClipping
  • animatePreset

A unified approach is used for all three to ensure consistent UX across all animation modes.

Implementation Details

  • Added label-hide logic at the beginning of each animation function:
    const labelsGroup = this.scene.getObjectByName(SceneManager.LABELS_ID);
    if (labelsGroup) labelsGroup.visible = false;

@Shivansh1205 Shivansh1205 force-pushed the fix-hide-labels-during-animation branch from f9f4f20 to 558f997 Compare November 30, 2025 12:33
fix(event-display): hide labels during animation until objects appear
@Shivansh1205 Shivansh1205 force-pushed the fix-hide-labels-during-animation branch from 558f997 to acdcdd5 Compare November 30, 2025 12:58
Comment thread packages/phoenix-event-display/src/managers/three-manager/animations-manager.ts Outdated
@EdwardMoyse EdwardMoyse merged commit afe15c4 into HSF:main Dec 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants