fix: upgrade tween.js to v25 with explicit group management#813
Merged
Conversation
Closes HSF#680 Signed-off-by: remo-lab <remopanda7@gmail.com>
63f9839 to
acec46c
Compare
Contributor
Author
|
@EdwardMoyse, Please give it a look whenever you have time ! |
Member
|
Thanks! This is great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, I upgraded
@tweenjs/tween.jsfrom v23 to v25, which fixes #680.In v25, tween.js removed implicit global group registration. That means tweens are no longer automatically tracked — they must be explicitly added to a
Groupand updated usinggroup.update(). Without this change, all tween-based animations silently fail.To address this:
I created a shared
TweenGroupinstance insideThreeManagerPassed this shared group to
AnimationsManager,ControlsManager, andSelectionManagerUpdated all
new Tween(obj)calls to explicitly pass the group:Replaced the global
tweenUpdate()call withtweenGroup.update(now)inside the render loopFixed a pre-existing bug where
tweenUpdate()was being called twice per frameWhat Was Broken (Before This Fix)
All tween-based animations were silently failing, including:
The +/- zoom buttons were unaffected because they directly manipulate the camera and don’t use tweens.
Test Plan
http://localhost:4200/atlasThis upgrade restores all tween-driven animations and aligns the project with the new tween.js v25 architecture.
Recording.2026-03-03.153652.2.mp4