fix: use distinct icon for collections info panel#870
Merged
Conversation
Collaborator
|
Thanks for this. Just a stupid question : I do not get what I see in the file changed. It seems that the EventData icon has some change, although it looks exactly the same. Do you get it ? |
Signed-off-by: rx18-eng <remopanda78@gmail.com>
rx18-eng
force-pushed
the
fix/distinct-panel-icons
branch
from
6d015ce to
7cbb895
Compare
Collaborator
Author
|
Yeah the icon graphic itself is the same - the only change in those SVG files is the id attribute (Capa_1 -> eventData). The menu-toggle component references icons using a fragment URL like eventData.svg#eventData, so the SVG root element's id needs to match the icon name. The old id="Capa_1" meant the fragment reference didn't resolve and the icon was invisible. Also rebased the branch on latest main so the diff should be cleaner now. |
Member
|
Good idea. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collections info and geometry browser both used the same info icon, making them hard to tell apart in the toolbar. Changed collections info to use the eventData icon (which already existed in assets but was unused). Also fixed the SVG id in both asset copies (Capa_1 -> eventData) so the fragment reference actually resolves.