Moves some UI elements under a More Information icon#916
Merged
Conversation
… icons and naming to be a bit more consistent
From Claude: The root cause was that [checked]="infoPanel?.showInfoPanel" read state via @ViewChild, which is undefined during the first render and resolves to the component instance only after ngAfterViewInit — causing Angular to see a value change mid-cycle (null → false). The fix tracks each panel's open/closed state with plain boolean properties (showInfoPanel, showEventBrowser, etc.) on MoreInfoComponent itself. These are always initialised to false, so [checked] never changes unexpectedly. The toggle methods update the local flag first, then delegate to the child component's toggleOverlay().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also updated the naming to be a bit more consistent, and tweaked the icons.
See #903 for some discussion related to this.
cc @sponce