You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Epunch ,Good work --- this is a strong submission and it covers the assignment requirements well. The main remaining issues are HTML semantics, layout markup, and keeping the PR focused.
What You Did Well
You included all 4 required data points: name, email, colour, and size.
Good use of fieldset and legend for semantic grouping.
Name and email validation are correctly set up.
Colour uses radio buttons and size uses a select, which fits the expected approach.
Fix / Improve
1. Do not use <p> for grouping form controls
You used <p> around inputs and radio options. For this assignment, use <div> instead.
<p> is for paragraphs of text, not for form layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
fieldsetandlegendwith three radio button options to ensure exactly one color is chosen.selectdropdown with all 6 required sizes (XS to XXL).required.<label>and using semantic grouping tags.Questions
Looking forward to your feedback. Thanks !