Catch unsupported transforms on armature#72
Merged
HailToDodongo merged 3 commits intoHailToDodongo:mainfrom Mar 8, 2026
Merged
Catch unsupported transforms on armature#72HailToDodongo merged 3 commits intoHailToDodongo:mainfrom
HailToDodongo merged 3 commits intoHailToDodongo:mainfrom
Conversation
Contributor
Author
|
As discussed, I threw in an epsilon comparison to avoid potential false-positives on very small transforms. I didn't notice any visual issues with the mesh / animations when adding tiny transforms to the armature that fall under the threshold. |
Contributor
Author
|
As mentioned on discord, I also think the armature transforms could be supported by tweaking the importer tool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check in the glTF parser to throw an error if any ancestor of a skin's root bones has transforms that would be lost in Tiny3D