Merged
Conversation
- Updated README.md to include detailed setup instructions, capabilities, tools, and prompts for the ProjGraph MCP server. - Introduced WorkspaceRootService to manage workspace root paths and resolve file paths against them. - Added progress notifications for tools to provide feedback during execution. - Enhanced existing tools to include new parameters for progress reporting. - Created comprehensive tests for prompts, resources, and progress reporting to ensure functionality and reliability. - Implemented caching for diagram resources with LRU eviction strategy. - Added integration tests for various functionalities including prompts, resources, and workspace root resolution.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds “MCP Integration Primitives” to ProjGraph.Mcp by extending the existing tools-only server with MCP Prompts, Resources, Roots-based path resolution, and progress notifications, plus accompanying specs and test coverage.
Changes:
- Introduces MCP primitives implementation (
ProjGraphPrompts,ProjGraphResources,DiagramResourceCache,WorkspaceRootService) and wires them into the MCP host. - Adds contract + integration tests covering prompts/resources/progress/roots behaviors.
- Updates supporting docs/specs and bumps tooling/config (SDK version, markdownlint rule).
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ProjGraph.Tests.Integration.Mcp/McpRootsTests.cs | Adds integration tests for root-based path resolution. |
| tests/ProjGraph.Tests.Integration.Mcp/McpResourcesTests.cs | Adds integration tests for welcome/diagram resources and cache behavior. |
| tests/ProjGraph.Tests.Integration.Mcp/McpPromptsTests.cs | Adds integration tests for prompt message content and structure. |
| tests/ProjGraph.Tests.Integration.Mcp/McpProgressTests.cs | Adds integration tests for 3-stage progress notifications per tool. |
| tests/ProjGraph.Tests.Integration.Mcp/Helpers/McpTestHelper.cs | Updates tool construction to include new MCP dependencies. |
| tests/ProjGraph.Tests.Contract/McpResourceContractTests.cs | Contract tests for resource attributes and cache constants. |
| tests/ProjGraph.Tests.Contract/McpPromptContractTests.cs | Contract tests for prompt attributes/signatures and content expectations. |
| tests/ProjGraph.Tests.Contract/McpProjectStatsContractTests.cs | Updates tool signature expectations to include progress parameter. |
| tests/ProjGraph.Tests.Contract/McpProjectGraphContractTests.cs | Updates tool signature expectations to include progress parameter. |
| tests/ProjGraph.Tests.Contract/McpErdContractTests.cs | Updates tool signature expectations to include progress parameter. |
| src/ProjGraph.Mcp/WorkspaceRootService.cs | Implements lazy roots capability detection + relative-path resolution. |
| src/ProjGraph.Mcp/README.md | Documents MCP tools/prompts/resources/roots/progress usage. |
| src/ProjGraph.Mcp/ProjGraphTools.cs | Adds progress reporting, resource caching, and root resolution to tools. |
| src/ProjGraph.Mcp/ProjGraphResources.cs | Adds welcome + diagram resource read handler. |
| src/ProjGraph.Mcp/ProjGraphPrompts.cs | Adds the 4 MCP prompt workflows. |
| src/ProjGraph.Mcp/Program.cs | Wires prompts/resources into MCP server and registers new services. |
| src/ProjGraph.Mcp/DiagramResourceCache.cs | Adds in-memory diagram/stat cache with eviction + notifications. |
| src/ProjGraph.Lib/ProjGraph.Lib.csproj | Removes redundant EF Core package reference from aggregator project. |
| src/ProjGraph.Lib.ProjectGraph/ProjGraph.Lib.ProjectGraph.csproj | Removes redundant DI package reference (now transitively available). |
| src/ProjGraph.Lib.EntityFramework/ProjGraph.Lib.EntityFramework.csproj | Removes redundant DI package reference (now transitively available). |
| src/ProjGraph.Cli/ProjGraph.Cli.csproj | Removes redundant DI package reference (now transitively available). |
| specs/012-mcp-integration-primitives/tasks.md | Adds implementation task breakdown and checkpoints for the feature. |
| specs/012-mcp-integration-primitives/spec.md | Adds the feature specification and acceptance scenarios. |
| specs/012-mcp-integration-primitives/research.md | Adds SDK research notes and decisions for primitives implementation. |
| specs/012-mcp-integration-primitives/quickstart.md | Adds usage examples for prompts/resources/roots/progress. |
| specs/012-mcp-integration-primitives/plan.md | Adds implementation plan and architecture notes. |
| specs/012-mcp-integration-primitives/data-model.md | Defines the in-memory entities used by the MCP primitives. |
| specs/012-mcp-integration-primitives/contracts/mcp-roots.md | Defines expected MCP Roots behavior and interactions. |
| specs/012-mcp-integration-primitives/contracts/mcp-resources.md | Defines resource URIs/templates and notification expectations. |
| specs/012-mcp-integration-primitives/contracts/mcp-prompts.md | Defines prompt names/args and expected message sequences. |
| specs/012-mcp-integration-primitives/checklists/requirements.md | Adds a specification quality checklist for the feature. |
| global.json | Bumps .NET SDK version. |
| .markdownlint.json | Disables MD041 to allow docs without top-level headings. |
| .github/agents/copilot-instructions.md | Updates “active technologies”/recent changes documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
This was referenced Mar 11, 2026
Contributor
Contributor
Contributor
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the contracts and quality checklist for the "MCP Integration Primitives" feature (012-mcp-integration-primitives), supporting the integration of ProjGraph with ModelContextProtocol (MCP) for advanced .NET solution analysis. The changes add detailed specifications for MCP resources, prompts, and roots, as well as implementation notes and requirements checklists. It also updates the .NET SDK version and disables a markdown lint rule for project documentation.
Key changes:
1. MCP Integration Primitives Contracts and Specification
2. Documentation and Configuration Updates
.github/agents/copilot-instructions.mdto reflect new active technologies and recent changes related to MCP integration primitives. [1] [2]MD041markdown lint rule in.markdownlint.jsonto allow documents without a top-level heading.global.jsonfrom 10.0.101 to 10.0.103 for compatibility with new features.