Refactor FindFileRecursively to skip excluded directories (bin/obj/.git/node_modules)#57
Closed
Copilot wants to merge 2 commits into012-mcp-integration-primitivesfrom
Closed
Conversation
…vely Co-authored-by: HandyS11 <62420910+HandyS11@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on mcp integration primitives regarding folder exclusions
Refactor FindFileRecursively to skip excluded directories (bin/obj/.git/node_modules)
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FindFileRecursivelyusedDirectory.GetFiles(..., SearchOption.AllDirectories)— eager, unbounded, and unaware of the project's standard skip list — making it expensive on large workspaces.Changes
WorkspaceRootService.FindFileRecursively: replaced the singleGetFilescall with an iterative stack-based DFS that appliesDirectoryFilters.ShouldSkipDirectorybefore descending into any subdirectoryDirectory.EnumerateFiles/EnumerateDirectories(lazy) over the eagerGetFiles/GetDirectories✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.