Plugin incorrectly flags commands in .sty file as duplicates

[jandermoreira]

I am using the TeXiFy plugin that is incorrectly identifying every custom command in my project's .sty file as a duplicate, despite there being no actual duplication.

I have already attempted to resolve this by selecting File > Invalidate Caches / Restart... but the issue persists.

Has anyone encountered this false-positive behavior before, and are there any known solutions or configuration settings to prevent it?

[PHPirates]

Thanks for raising this issue, we recently changed a lot of things related to this, so any reproducible examples with issues would be very helpful.

Which version of TeXiFy are you using?

[jandermoreira]

I'm struggling to reproduce the issue, but without success.

Perhaps I can share the complete project to see if someone else can replicate the situation.

I can send the files for analysis, if appropriate.

[jandermoreira]

The issue occurs for me when a package is already installed (by TeXLive, for example) and I have another .sty file with the same name and same commands in my project.

Since I'm editing my own package which is also available in TeXLive, this is exactly my situation.

To reproduce it, simply pretend you are the author of an existing, installed package.

The following steps use Benjamin McKay's lie-hasse package, chosen randomly.

• Create a new project
• Create a file named lie-hasse.sty
• Insert the command \NewDocumentCommand{\edgeQuote}{ m }{} into this file (Note: \edgeQuote is a command that already exists in the original package)
• In the main.tex file, add \usepackage{lie-hasse}

In my working environment, this is sufficient for \edgeQuote to be flagged as a duplicate.

My assumption is that the plugin loads the known, already indexed commands when it encounters the \usepackage declaration. Consequently, the commands from the local file—which is the one actually used in the project—are then seen as duplicates of the original ones.

[PHPirates]

Thanks, I can reproduce the issue! It occurs because at the point the package is input, it resolves to both the local and the installed package, while it should only resolve to the local one.

[jandermoreira]

Any news on this issue? :-)

[PHPirates]

I don't remember whether I fixed the issue, looking at my last comment. But pull requests are much appreciated!

[jandermoreira]

This works locally on my machine.
I’m not entirely sure about the pull request process yet, so I’m sharing the relevant code here.
Further testing may be required.

Hope this helps!

File: LatexProjectStructure.kt

 private fun processLibraryReferences(
     elements: List<Sequence<Path>>, refInfoList: List<MutableSet<VirtualFile>>
 ) {
     for ((paths, refInfo) in elements.zip(refInfoList)) {
         for (path in paths) {
+            // local packages first
+            val localFile =
+                if (path.isAbsolute) {
+                    path.findVirtualFile()
+                }
+                else {
+                    currentRootDir?.findFileByRelativePath(path.invariantSeparatorsPathString)
+                        ?: rootDirs.firstNotNullOfOrNull { dir ->
+                            dir.findFileByRelativePath(path.invariantSeparatorsPathString)
+                        }
+                }
+
+            if (localFile != null) {
+                processNext(localFile)
+                refInfo.add(localFile)
+                continue
+            }
+
             val libraryInfo =
                 LatexLibraryStructureService.getInstance(project).getLibraryInfo(path, root)
             if (libraryInfo != null) {
                 addLibrary(libraryInfo)
                 refInfo.add(libraryInfo.location)
             }
             else {
                 // even though we cannot find the library, we still add it to the libraries set
                 // so that the definition service can still find it
                 libraries.add(path.name)
             }
         }
     }
 }

[PHPirates]

I think something like that should work! If you are interested in learning how to create a pull request, it's not difficult, see Contributing.md:

1. Click the 'fork' button on the upper right corner of this repository to create your own copy of the project
2. Clone the forked repository
3. Create a branch, and push changes to your fork
4. Create a pull request from the fork to this repository