feat(desktop): show fleet coordinator status - #100
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…#102) * feat(desktop): checkpoint Windows tray seams [wip] * docs(tender): describe Windows tray support and gate a Unix-only test Harborline Toolbox now ships as a Windows tray app (platform.rs opener/home_dir seam, tauri-plugin-autostart integration) from an earlier checkpoint, but the README and product spec still described macOS only. Document both platforms end to end: install/build steps, the platform-seam table, start-at-login mechanism differences, and the per-user MSI/NSIS installer nuance (Tauri's WiX bundler has no perUser install-scope option yet -- upstream feature request tauri-apps/tauri issue 13792 -- so the NSIS installer is the per-user, no-elevation-required path today; the MSI is per-machine). Also gate stop_by_pattern_terminates_a_live_process_then_reports_none as Unix-only: it spawns bash and relies on pkill -f, neither of which exist on Windows, and stop_by_pattern itself has no Windows backend yet (pre-existing gap, unrelated to the tray work). Verified clean on a Windows x64 build: MSI builds without remediation, cargo test --lib is 124/0/3 (was 123/1/3), frontend build passes, and the installed app launches in the logged-on desktop session (not Session 0) with a real notification-area icon that opens the panel on click. Refs: tender#2956
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
on color alone
Why
Tender is the fleet cockpit. Operators need to see whether the single assignment authority is
reachable and authenticated, while connection targets remain install- and customer-specific
settings rather than hard-coded developer-machine values.
Security and behavior
Validation
npm run buildcargo test --lib(124 passing, 3 ignored)Stacking
This draft targets
feat/daemon-visibilityso its diff contains only coordinator visibility andconfiguration. Retarget to
mainafter the prerequisite daemon-visibility PR lands.