Rando: Adds Bombchu Refills to junk pool if drops are on

[leggettc18]

Simple as the title, adds bombchu refills to the possible items to fill in as junk items, but only if Enable Bombchu Drops is on.

Build Artifacts

• soh-windows.zip
• soh-linux.zip
• soh-mac.zip

[Pepper0ni]

This should only apply when Bombchu Bags are on (in either form) as you don't get drops until you have a bombchu icon, and if you can't buy bombchus (e.g. because no wallet) you need to find the first bombchu to get a drop. There's also the case that you don't have bomb bag yet and can get logic breaking chus.

It is a weird edge case though, and another reason I consider Bag off to be a legacy setting for compatability with N64 racing movesets, and would agree to marking them as Lesser when bag is off.

[leggettc18]

I will need to do more testing but I believe there is already logic to make sure if you haven't gotten Chus, these junk items become blue rupees as soon as they spawn, just like regular bombs would. I will double check this though.

[Pepper0ni]

Does this apply even when Bombchu Bags are off? I assumed that was unchanged from the oldest implementation and allowed you to get out of logic bombchus.

[leggettc18]

You are correct, I thought it would be blupee'd but I was wrong.

[chartergirl64]

Bombchus (20) refill appear as bombchu bags instead of solo bombchus - both of these are refills, one is 20 and one is 5 or 10 idr

[leggettc18]

Well it butchered the commit message but I found that the culprit was the Randomizer_DrawBombchuBagInLogic function, which was a holdover from before bombchu bags were their own item and was no longer needed. It wasn't noticed before because there were no bombchu pickups shuffled in as junk items before this.

[leggettc18]

Removed the RG_BOMBCHUS_20 from the Junk Pool. During a recent playtest it felt like there were a lot of chu refills in general, but especially I felt like I was seeing too many 20s. Since we don't currently have a good way to weight these I opted to remove the 20 capacity refill from the possible junk items, resulting in lower capacity upgrades and fewer refills in general. Chus are pretty powerful so it feels appropriate that they are, relatively speaking, rarer than the other ammo types.