Hookify Shooting Gallery options - #6972
Conversation
| s32 ammunition = 15; | ||
| if (CVarGetInteger(CVAR_ENHANCEMENT("CustomizeShootingGallery"), 0)) { | ||
| ammunition = CVarGetInteger(LINK_IS_ADULT ? CVAR_ENHANCEMENT("ShootingGalleryAmmoAdult") | ||
| : CVAR_ENHANCEMENT("ShootingGalleryAmmoChild"), | ||
| 15); | ||
| } | ||
| GameInteractor_Should(VB_SET_SHOOTING_GALLERY_AMMO, true, &ammunition); | ||
| func_8008EF44(play, ammunition); |
There was a problem hiding this comment.
I'm not sure if this kind of pattern is good for our current standards, at the beginning of VB it wasn't but that might have changed since then.
There was a problem hiding this comment.
Would our "current standards" involve only using GameInteractor_Should as a conditional? I think that's how it would've been used at first, but it's more flexible than that. Making this change is easier than using an if statement and putting func_8008EF44 inside the hook.
I'm not thrilled with it either, but that's just how it is.
There was a problem hiding this comment.
Our current standards have changed, & with #6468 at some point I'm in no rush to refactor for non-conditional VB
There was a problem hiding this comment.
I'm adding plenty of work to that migration with these added minigame hooks. 😅
3 participants
null
Build Artifacts