cherry-pick: Warn loudly when config-shaping env vars arrive via component .env files (not honored) (conflicts → v5.1)#1754
Merged
Conversation
Warn loudly when config-shaping env vars arrive via component .env files (not honored)
v5.1's loadEnv predates the env-secrets machinery on main; the patch takes only the #1513 warn-and-skip against v5.1's file shape. DESIGN.md takes the incoming sections. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Conflicts resolved (9b61349 + 0b118c4), deliberately minimal for the release line:
Verified in the branch: 14 unit tests + the flipped integration test (fixture delivers Comment generated by an LLM (Claude Fable 5). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #1580 onto `v5.1` produced conflicts on commit(s): `0e80b6bdbe8b46e5162d55419d53ffac952df7bc`.
Resolve the conflict markers on branch `cherry-pick/v5.1/pr-1580` and merge this PR.
@claude please review branch `cherry-pick/v5.1/pr-1580` and suggest a patch that resolves the conflict markers (
<<<<<<</=======/>>>>>>>) introduced by cherry-picking PR #1580 onto `v5.1`. Post the suggested patch as a comment here — do not push.