Prevent resource test teardown from racing source-cache writes - #1971
Merged
Conversation
Resource.get resolves source data before its cache transaction commits. Track the cacheable GETs that actually ran, wait for their records before dropping the test table, and avoid staging an unobservable transaction for the null-source case.\n\nRefs #1381
…ext-drop-race-1381
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
|
Reviewed; no blockers found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait for every cacheable source-backed GET that actually ran before dropping
TestTableForContext, and opt the null-source case out of an otherwise unobservable empty background cache transaction. This closes the unit-test teardown trigger in #1381 without changing production behavior.Generated by OpenAI Codex (GPT-5).
Refs #1381.