Format query-array-scoping test so the main Format Check passes again - #2464
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the formatting of two test assertions in unitTests/resources/query-array-scoping.test.js by condensing multi-line assert.deepStrictEqual calls into single-line statements. There are no review comments, and I have no feedback to provide.
Contributor
|
Reviewed; no blockers found. |
Member
|
Reviewed ad16bbd and found no blocking issues. The changes only apply Prettier formatting and preserve behavior. No blocking findings were identified. — |
cb1kenobi
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test file added in "Pin element-scoping semantics of queries over array-valued properties (#2437)" was not run through Prettier, so
npm run format:checkhas failed onmainsince eeadbdd and every open PR inherits the red Format Check. This is the output ofnpx prettier --write unitTests/resources/query-array-scoping.test.jswith no other changes: twoassert.deepStrictEqualcalls collapsed onto fewer lines (the indexed-array assertion and the string-value assertion). Whitespace-stripped, the file is byte-identical toorigin/main: the query strings (sizesIdx=ge=175&sizesIdx=le=180,{ attribute: 'sizes', comparator: 'contains', value: '17' }), the collectors (collectUniqueIds/collectIds, not swapped) and the expected id arrays are all unchanged, so what the suite proves is identical before and after.For the human reviewer
One open decision, and it is yours rather than the diff's: this fix is a standalone follow-up commit rather than an amend/force-push of the original array-scoping PR (eeadbdd). The trade is history legibility against how long
maincarries a red Format Check; it is trivially reversible either way, but only before this lands.Cross-model pre-push review ran at this head and found nothing: codex (graded) and cursor-composer both reported zero findings, and the Harper domain pass confirmed zero runtime surface. One caveat on coverage — the gemini leg could not run (local CLI not authenticated), so this round is 2 of 4 selected lenses.
Codex noted the branch trails
origin/mainby ten commits and suggested rebasing before landing. Left as-is deliberately: GitHub reports the PRMERGEABLE, none of the intervening commits touch this file, and a rebase would force-push a new head whose only effect is to invalidate the review receipt above.Verification
Route: the CI gate itself. Locally,
npx prettier --check .reports "All matched files use Prettier code style!" on this branch, andnpm run format:checkon this PR's Format Check job is the end-to-end confirmation. Independently re-confirmed thatmain's newest Format Check run still names exactly this one file, so this PR is the whole fix. No behavior change to test.Complexity: easy
🤖 Generated with Claude Code
Review-Coverage: authored=claude; ran=codex,cursor-composer; adjudicated=domain; blocked=gemini(auth); declined=cursor-grok; rounds=1 @ ad16bbd
Human-Review-Need: 3 (decisions: formatting-fixup-as-separate-commit) @ ad16bbd