Skip to content

Format query-array-scoping test so the main Format Check passes again - #2464

Merged
kriszyp merged 1 commit into
mainfrom
kris/format-query-array-scoping-test
Sep 2, 2026
Merged

Format query-array-scoping test so the main Format Check passes again#2464
kriszyp merged 1 commit into
mainfrom
kris/format-query-array-scoping-test

Conversation

@kriszyp

@kriszyp kriszyp commented Sep 2, 2026

Copy link
Copy Markdown
Member

The test file added in "Pin element-scoping semantics of queries over array-valued properties (#2437)" was not run through Prettier, so npm run format:check has failed on main since eeadbdd and every open PR inherits the red Format Check. This is the output of npx prettier --write unitTests/resources/query-array-scoping.test.js with no other changes: two assert.deepStrictEqual calls collapsed onto fewer lines (the indexed-array assertion and the string-value assertion). Whitespace-stripped, the file is byte-identical to origin/main: the query strings (sizesIdx=ge=175&sizesIdx=le=180, { attribute: 'sizes', comparator: 'contains', value: '17' }), the collectors (collectUniqueIds / collectIds, not swapped) and the expected id arrays are all unchanged, so what the suite proves is identical before and after.

For the human reviewer

One open decision, and it is yours rather than the diff's: this fix is a standalone follow-up commit rather than an amend/force-push of the original array-scoping PR (eeadbdd). The trade is history legibility against how long main carries a red Format Check; it is trivially reversible either way, but only before this lands.

Cross-model pre-push review ran at this head and found nothing: codex (graded) and cursor-composer both reported zero findings, and the Harper domain pass confirmed zero runtime surface. One caveat on coverage — the gemini leg could not run (local CLI not authenticated), so this round is 2 of 4 selected lenses.

Codex noted the branch trails origin/main by ten commits and suggested rebasing before landing. Left as-is deliberately: GitHub reports the PR MERGEABLE, none of the intervening commits touch this file, and a rebase would force-push a new head whose only effect is to invalidate the review receipt above.

Verification

Route: the CI gate itself. Locally, npx prettier --check . reports "All matched files use Prettier code style!" on this branch, and npm run format:check on this PR's Format Check job is the end-to-end confirmation. Independently re-confirmed that main's newest Format Check run still names exactly this one file, so this PR is the whole fix. No behavior change to test.

Complexity: easy

🤖 Generated with Claude Code

Review-Coverage: authored=claude; ran=codex,cursor-composer; adjudicated=domain; blocked=gemini(auth); declined=cursor-grok; rounds=1 @ ad16bbd

Human-Review-Need: 3 (decisions: formatting-fixup-as-separate-commit) @ ad16bbd

The test file landed in #2437 unformatted, so `prettier --check` has failed
on main since eeadbdd and every open PR inherits the red Format Check.
Pure whitespace change from `prettier --write`.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the formatting of two test assertions in unitTests/resources/query-array-scoping.test.js by condensing multi-line assert.deepStrictEqual calls into single-line statements. There are no review comments, and I have no feedback to provide.

@kriszyp
kriszyp requested a review from cb1kenobi September 2, 2026 02:24
@kriszyp kriszyp added this to the v5.3 milestone Sep 2, 2026
@kriszyp
kriszyp marked this pull request as ready for review September 2, 2026 02:34
@claude

claude Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Reviewed; no blockers found.

@cb1kenobi

Copy link
Copy Markdown
Member

Reviewed ad16bbd and found no blocking issues. The changes only apply Prettier formatting and preserve behavior. No blocking findings were identified.


Generated by Barber AI

@kriszyp
kriszyp merged commit 5cf4e0d into main Sep 2, 2026
53 checks passed
@kriszyp
kriszyp deleted the kris/format-query-array-scoping-test branch September 2, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants