Fix multiple HNSW bugs causing intermittent search quality issues - #371
Merged
Conversation
kriszyp
commented
Apr 17, 2026
kriszyp
commented
Member
- Only replace entry point when new node level is strictly higher, not equal, to avoid replacing well-connected entry points with unconnected new nodes
- Use passed distance function for entry point in searchLayer instead of always using the instance default, which mixed distance metrics
- Prevent orphaning nodes at level 0 when pruning excess connections
- Update stale distances in reverse connections when a node's vector changes
- Only replace entry point when new node level is strictly higher, not equal, to avoid replacing well-connected entry points with unconnected new nodes - Use passed distance function for entry point in searchLayer instead of always using the instance default, which mixed distance metrics - Prevent orphaning nodes at level 0 when pruning excess connections - Update stale distances in reverse connections when a node's vector changes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
heskew
reviewed
Apr 17, 2026
heskew
approved these changes
Apr 17, 2026
Co-authored-by: Nathan Heskew <heskew@pm.me>
dawsontoth
approved these changes
Apr 17, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.