Skip to content

Studio 264 2#584

Merged
dawsontoth merged 5 commits into
harper/fabricfrom
STUDIO-264-2
Aug 29, 2025
Merged

Studio 264 2#584
dawsontoth merged 5 commits into
harper/fabricfrom
STUDIO-264-2

Conversation

@kriszyp

@kriszyp kriszyp commented Aug 29, 2025

Copy link
Copy Markdown
Member

This the rest of #578, as I think Dawson did a force-push that removed this commit (and I have merged/resolved the conflict with harper/fabric).

https://harperdb.atlassian.net/browse/STUDIO-264

@kriszyp
kriszyp requested a review from a team as a code owner August 29, 2025 11:46
@kriszyp
kriszyp requested a review from dawsontoth August 29, 2025 11:46
Comment thread src/features/clusters/upsert/ClusterDetails.tsx Outdated
@sonarqubecloud

sonarqubecloud Bot commented Aug 29, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dawsontoth dawsontoth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I made a few minor adjustments.

  1. The largest thing I did was use the expiration months in the other places of the codebase that were hard coded to say 3 months. Now we'll respect whatever the selected plan dictates to us.
  2. I added a isPositive function that narrows the type too, letting me remove the type assertions. It also has the benefit of communicating that we want to make sure the number is defined, but also that it isn't negative (because -1 communicates unlimited, right?) so a future dev won't say "hey, we could replace this with a truthy check!" and break stuff.
  3. I tweaked the wrapping a little bit so that it will <br /> where Kris wants, but also not do that when we're on the smallest viewports. That would result in fragmented lines.
  4. I added a <ContactUs /> component for that anchor tag we had in a few spots, mostly so that our line wraps can be cleaner 😆
    If you hide whitespace in this PR, the diff will be a lot easier to see.

@dawsontoth
dawsontoth requested a review from BboyAkers August 29, 2025 15:47
@dawsontoth
dawsontoth merged commit 41e4bdf into harper/fabric Aug 29, 2025
1 check passed
@dawsontoth
dawsontoth deleted the STUDIO-264-2 branch August 29, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants