Studio 264 2#584
Merged
Merged
Conversation
dawsontoth
reviewed
Aug 29, 2025
|
dawsontoth
approved these changes
Aug 29, 2025
dawsontoth
left a comment
Contributor
There was a problem hiding this comment.
OK I made a few minor adjustments.
- The largest thing I did was use the expiration months in the other places of the codebase that were hard coded to say 3 months. Now we'll respect whatever the selected plan dictates to us.
- I added a
isPositivefunction that narrows the type too, letting me remove the type assertions. It also has the benefit of communicating that we want to make sure the number is defined, but also that it isn't negative (because-1communicates unlimited, right?) so a future dev won't say "hey, we could replace this with a truthy check!" and break stuff. - I tweaked the wrapping a little bit so that it will
<br />where Kris wants, but also not do that when we're on the smallest viewports. That would result in fragmented lines. - I added a
<ContactUs />component for that anchor tag we had in a few spots, mostly so that our line wraps can be cleaner 😆
If you hide whitespace in this PR, the diff will be a lot easier to see.
BboyAkers
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This the rest of #578, as I think Dawson did a force-push that removed this commit (and I have merged/resolved the conflict with harper/fabric).
https://harperdb.atlassian.net/browse/STUDIO-264