feat(engine): add linediff engine and universal line diff fallback - #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
diffmpreviously failed with a hard parse error. So unsupported file formats and plaintext files couldn't be diffed.What Changed
LineDiff(linesA, linesB)ininternal/engine/linediff.gousing a 1D DP flat slice and prefix/suffix line trimming.BuildLineDiffEnvelopeininternal/serialize/json.goand updatedcomputeDiffincmd/pipeline.go. When AST parsing fails or file extensions are unsupported, CLI and TUI fall back to line-level diffing instead of erroring out.generateLineDiffhelper ininternal/tui/model.goto useserialize.BuildLineDiffEnvelope.internal/engine/linediff_test.gofor line trimming edge cases and addedTestDiffFallbackLineDiffincmd/diff_test.go.