fix(fpc): fix callback compatibility with official middlewares (issue… - #499
Merged
viniciussanchez merged 1 commit intoJul 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrição
Este Pull Request resolve a issue #498 ao restaurar a compatibilidade reversa para atribuição de callbacks procedurais a
THorseCallbackno Free Pascal Compiler (FPC) sem exigir o operador de endereço (@). Ele garante que a sintaxe herdada usada pelos middlewares oficiais compile perfeitamente no FPC, mantendo a proteção interna de segurança.Contexto & Alterações
1. Callbacks Transparentes no FPC (
src/Horse.Callback.pas)THorseCallbackcomo umrecordencapsulando umPointergenérico sob o compilador FPC.class operator Implicit) para converter de/para:PointerTHorseCallbackProcTHorseCallbackRequestTHorseCallbackResponseTHorseCallbackRequestResponseResult := MyCallbackou a passagem direta do nome da procedure compilem sem que o compilador acuse incompatibilidade de tipos procedurais.2. Ajustes nos Arrays de Wrappers (
src/Horse.Core.Wrappers.inc)GWrapperList1eGWrapperList2paraPointer.@W1_0), a mudança paraPointerviabiliza a compilação. Os operadores implícitos do record garantem que a conversão ocorra de forma transparente e segura ao ler esses ponteiros emHorse.Core.pas.3. Verificação e Testes
TestFPCLegacyCallbackAssignmentpara validar que a atribuição de callbacks de sintaxe legada compila sem problemas.samples/lazarus/test_issue498/utilizando os 5 middlewares oficiais (jhonson,horse-compression,horse-basic-auth,horse-corsehorse-octet-stream).