Fix/epoll iocp headers - #510
Merged
regyssilveira merged 4 commits intoJul 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Fix HTTP headers and response body mapping on async/high-performance providers
Description
This PR resolves the issue where custom/standard HTTP headers and response contents (such as JSON generated by middlewares) were not correctly delivered or sent when using asynchronous and high-performance providers (
epoll,IOCP, andHttpSys).Key Fixes:
HTTP Headers Mapping:
PopulateHeadersmethod to theIHorseRawRequestinterface.PopulateHeadersinTEpollRawRequest,TIocpRawRequest, andTHttpSysRawRequest(extracting headers dynamically according to the requestedNameValueSeparator).THorseCoreParamHeader.GetHeadersListto delegate toPopulateHeadersif the web request is aTInterfacedWebRequest.Response Content Delivery:
ContentandContentStreamproperties on the DelphiTInterfacedWebResponseadapter class.SendResponseroutine in bothepollandIOCPproviders to extract and output data from the adapter'sContent/ContentStreamproperties when populated.Compiler and Version Compatibility:
GetRawContentinside appropriate version conditionals (CompilerVersion >= 32.0).TEncoding.UTF8.GetStringwith standardSetString(zero-allocation and cross-compiler compatible) in the FPC/epoll provider code.Integration Testing:
Tests.Api.Console.pas).-dHORSE_PROVIDER_EPOLLon Lazarus integration tests within the Docker container.Validation and Tests
IOCPandHttpSysproviders. All tests passed.epollloop inside the Lazarus docker container. All integration tests succeeded.